[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH 04/11] include/uk/list: rename UK_LIST_HEAD in the old implementation



Hello Yuri,

This patch seems fine. I do not mind retaining the UK_LIST interface but my suggestion would be to remove the LIST interface from the compat_list.h. If we were to port the irq implementation from the linuxu and kvm platform to the newer list we could also remove the UK_SLIST interface as well.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

On 12/5/18 6:23 PM, Yuri Volchkov wrote:
UK_LIST_HEAD from the new list implementation conflicts with the old
one. Since the current UK_LIST_HEAD is never used, and the current
implementation will be a subject for removal, rename it to
UK_COMPAT_LIST_HEAD

Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
---
  include/uk/compat_list.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uk/compat_list.h b/include/uk/compat_list.h
index 4e350cd..7136e0c 100644
--- a/include/uk/compat_list.h
+++ b/include/uk/compat_list.h
@@ -458,7 +458,7 @@ struct {                                                    
        \
  /*
   * List declarations.
   */
-#define        UK_LIST_HEAD(name, type)                                        
        \
+#define        UK_COMPAT_LIST_HEAD(name, type)                                 
\
  struct name {                                                         \
        type *lh_first; /* first element */                     \
  }


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.