Re: [Minios-devel] [UNIKRAFT PATCH 06/11] include/uk/list: remove unneeded workarounds from imported code

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Yuri,

This patch is fine.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

On 12/5/18 6:23 PM, Yuri Volchkov wrote:
> This implementation of lists intended to be the only one and going to
> replace the existing one completely. There is no need of LIST_HEAD
> conflict avoidance. The prefetch is not belong here either.
>
> Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
> ---
>   include/uk/list.h | 9 ---------
>   1 file changed, 9 deletions(-)
>
> diff --git a/include/uk/list.h b/include/uk/list.h
> index 9822005..2ea27da 100644
> --- a/include/uk/list.h
> +++ b/include/uk/list.h
> @@ -34,22 +34,16 @@
>   #include <uk/arch/atomic.h>
>   #include <stddef.h>
>   
> -#ifndef prefetch
> -#define        prefetch(x)
> -#endif
>   
>   #define LINUX_LIST_HEAD_INIT(name) { &(name), &(name) }
>   
>   #define LINUX_LIST_HEAD(name) \
>         struct list_head name = LINUX_LIST_HEAD_INIT(name)
>   
> -#ifndef LIST_HEAD_DEF
> -#define        LIST_HEAD_DEF
>   struct list_head {
>         struct list_head *next;
>         struct list_head *prev;
>   };
> -#endif
>   
>   static inline void
>   INIT_LIST_HEAD(struct list_head *list)
> @@ -269,9 +263,6 @@ list_splice_tail_init(struct list_head *list, struct 
> list_head *head)
>         INIT_LIST_HEAD(list);
>   }
>   
> -#undef LIST_HEAD
> -#define LIST_HEAD(name)        struct list_head name = { &(name), &(name) }
> -
>   
>   struct hlist_head {
>         struct hlist_node *first;
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel