[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v2 3/8] lib/uksched: Introduce thread attributes


  • To: Florian Schmidt <Florian.Schmidt@xxxxxxxxx>, Costin Lupu <costin.lup@xxxxxxxxx>, minios-devel@xxxxxxxxxxxxx
  • From: Costin Lupu <costin.lupu@xxxxxxxxx>
  • Date: Wed, 23 Jan 2019 16:59:52 +0200
  • Cc: felipe.huici@xxxxxxxxx, simon.kuenzer@xxxxxxxxx, yuri.volchkov@xxxxxxxxx
  • Delivery-date: Wed, 23 Jan 2019 14:59:58 +0000
  • Ironport-phdr: 9a23:H1awCRDRee8WAhcEcWAVUyQJP3N1i/DPJgcQr6AfoPdwSP36oMSwAkXT6L1XgUPTWs2DsrQY07qQ6/iocFdDyK7JiGoFfp1IWk1NouQttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXdrXKo8DEdBAj0OxZrKeTpAI7SiNm82/yv95HJbAhEmDmwbaluIBmqsA7cqtQYjYx+J6gr1xDHuGFIe+NYxWNpIVKcgRPx7dqu8ZBg7ipdpesv+9ZPXqvmcas4S6dYDCk9PGAu+MLrrxjDQhCR6XYaT24bjwBHAwnB7BH9Q5fxri73vfdz1SWGIcH7S60/VC+85Kl3VhDnlCYHNyY48G7JjMxwkLlbqw+lqxBm3oLYfJ2ZOP94c6jAf90VWHBBU95MWSJfDIOyb4gBAeQPMulXrYbyu1QAoACiBQm1Hu7j1iNEi3H00KA8zu8vERvG3AslH98WrnnUq871NLsTUeCz0aLGyyjDb+tL2Tzg74XHbhchoeqQXbJxd8rd000vFx7djlWNsoHqIyiV2v4Vs2iG9OVsT/ivi2k+pgx3vzOhxd8sh5HUio8a11zI7yZ0zYYvKdGmVkJ2Y8SoHZVIuy2HOIZ6X9kuTmJotSog1LELt5C2cDIXxJko2RLSbeGMfZKS7RL5TumRJC91hHdieL2imRm/6VOgyujgVsms11ZKszZFnsHMtn8T0xzT7dCKSuV4/ki72DaP0xrf5f1fIUwujarbNoUuzqQqlpoUqUjDHyn2l1vqjKKOa0kp9fWk5/7kb7jmvJOQKZF4hwPkPqkggsC/BP43MgkKX2iV4+S807jj8FXlT7VNlf02jqjZsJbAKcQfu665GxJV350/5BakFTumyMkYkmIdIFJffxKLl5LpNE3WIPDkEfe/hEyhnytsx/DdIr3hA5PNImLHkLf8ZbZw8EFcyA8pwtBe45JYEK0OIPX2WkXprtzXEgc5MxCow+bgENh904IeWWSOAq+eK6PeqEKH6fwxI+aSYI8YozL9K/k+5/7yln81g1Accrev3ZcNb3C4BPtmKV2DYXXwmtcBDXsKvg0mQeLqjF2CViRTZ3eoUKI6/D01FZ6pDYfGRoCsnbOBwDy2HptIaW9aDlCDC2zne5+aVPcRcCiSONNukiQYVbi9TI8szR+uuxH+y7pmNurb5DcUtZL+1Nh0++LTlAo/9TpqAMuB12GCVXp7knkWSD8rxKp/u1Byyk+f0ahkhPxVDcdT5/JMUgc9M57Q1e96C83sVQLHf9aGVkymT86gAT4vUt0xx8UBbF1nF9q8kxDJxzCqDKMNl7yXGJw09brR3njsJ8ZnynbKzrchj14iQsRTNW2mhal/9xbICo7PjUqWi6Kqer4H0yLX6miD0DnGgEYNfgp3S6TMWzgkbUvTrNjlrhfsS7i0CL0hdDBKycuDJrdibNDiiVxMAvr+bpCWSGWqh2a2TTKV3q7EOIHtYHkc2mPZFVAsnAUa/HLAPg87UGPppmPYDTt1UF7ifU7o2e1/s2+gCF85yUeNdUIy+aCy/0s+gueASvVb+q8cpW91oDJvAFe7mdbLE8eorBEnZLhWJ8k6tgQUnVnFvhBwa8TzZ5tpgUQTJkEu5xvj
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>

On 1/23/19 3:56 PM, Florian Schmidt wrote:
> Hi Costin,
> 
> On 1/23/19 7:31 PM, Costin Lupu wrote:
>> Hi Florian,
>>
>> On 1/23/19 10:49 AM, Florian Schmidt wrote:
>>> Hi Costin,
>>>
>>> I checked Felipe's comments, and I agree with your changes in v2. he
>>> patch looks good to me, except for one minor thing:
>>>
>>> On 1/11/19 12:22 AM, Costin Lupu wrote:
>>>> diff --git a/lib/uksched/include/uk/thread_attr.h
>>>> b/lib/uksched/include/uk/thread_attr.h
>>>> new file mode 100644
>>>> index 0000000..93dcd5c
>>>> --- /dev/null
>>>> +++ b/lib/uksched/include/uk/thread_attr.h
>>>> @@ -0,0 +1,81 @@
>>>> +/* SPDX-License-Identifier: BSD-3-Clause */
>>>> +/*
>>>> + * Authors: Costin Lupu <costin.lupu@xxxxxxxxx>
>>>> + *
>>>> + * Copyright (c) 2019, NEC Europe Ltd., NEC Corporation. All rights
>>>> reserved.
>>>> + *
>>>> + * Redistribution and use in source and binary forms, with or without
>>>> + * modification, are permitted provided that the following conditions
>>>> + * are met:
>>>> + *
>>>> + * 1. Redistributions of source code must retain the above copyright
>>>> + *    notice, this list of conditions and the following disclaimer.
>>>> + * 2. Redistributions in binary form must reproduce the above
>>>> copyright
>>>> + *    notice, this list of conditions and the following disclaimer in
>>>> the
>>>> + *    documentation and/or other materials provided with the
>>>> distribution.
>>>> + * 3. Neither the name of the copyright holder nor the names of its
>>>> + *    contributors may be used to endorse or promote products derived
>>>> from
>>>> + *    this software without specific prior written permission.
>>>> + *
>>>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
>>>> CONTRIBUTORS "AS IS"
>>>> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
>>>> TO, THE
>>>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>>>> PURPOSE
>>>> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
>>>> CONTRIBUTORS BE
>>>> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>>>> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>>>> PROCUREMENT OF
>>>> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
>>>> BUSINESS
>>>> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
>>>> WHETHER IN
>>>> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
>>>> OTHERWISE)
>>>> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
>>>> ADVISED OF THE
>>>> + * POSSIBILITY OF SUCH DAMAGE.
>>>> + *
>>>> + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>> + */
>>>> +
>>>> +#ifndef __UK_SCHED_THREAD_ATTR_H__
>>>> +#define __UK_SCHED_THREAD_ATTR_H__
>>>> +
>>>> +#include <uk/arch/time.h>
>>>> +
>>>> +#ifdef __cplusplus
>>>> +extern "C" {
>>>> +#endif
>>>> +
>>>> +#define UK_THREAD_ATTR_WAITABLE         0
>>>> +#define UK_THREAD_ATTR_DETACHED         1
>>>> +
>>>> +#define UK_THREAD_ATTR_PRIO_INVALID     (-1)
>>>> +#define UK_THREAD_ATTR_PRIO_MIN         0
>>>> +#define UK_THREAD_ATTR_PRIO_MAX         255
>>>> +#define UK_THREAD_ATTR_PRIO_DEFAULT     127
>>>> +
>>>> +#define UK_THREAD_ATTR_TIMESLICE_NIL    0
>>>> +
>>>> +typedef int prio_t;
>>>> +
>>>> +typedef struct uk_thread_attr {
>>>> +    /**< Is non-zero if thread should detach */
>>>> +    int is_detached;
>>>> +    /**< Priority */
>>>> +    prio_t prio;
>>>> +    /**< Time slice in nanoseconds */
>>>
>>> Is there some reason for this comment style? (double-asterisk and
>>> less-than)
>>
>> Yeah, this was initially copied from 'common/include/pci/pci_bus.h' and
>> 'common/pci_bus.c' and it was also propagated to Xenbus source code.
> 
> I see. But I guess since it's now in unikraft, we can use our own
> comment style, right?
> 

The files where that was copied from *are in Unikraft*. Where can I find
the documentation of our comment style?

Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.