Re: [Minios-devel] [UNIKRAFT PATCH v2 5/8] lib/uksched: Add support for waiting threads

[Costin Lupu <costin.lup@xxxxxxxxx>]

On 1/23/19 5:07 PM, Florian Schmidt wrote:
> 
> 
> On 1/23/19 11:49 PM, Costin Lupu wrote:
>> On 1/23/19 3:48 PM, Florian Schmidt wrote: >> I understand that this
>> probably is a crazy corner case, and I'm not sure
>>> I can even ever occur without SMP support, but, on the other hand: is
>>> there any harm in switching the order? And actually, wouldn't it make
>>
>> It doesn't occur without SMP support. I'm not sure I understand what you
>> mean by switching the order and the reason behind it.
> 
> My point is: is there any harm in doing the uk_thread_exit() first, and
> then adding it to the list? It seems to me like this order is less prone
> to break, even if at the current stage of the code it will not break
> because we don't have SMP.

This change would be totally unnecessary now considering that for adding
SMP support to this code would require more changes and it may even need
rewriting of some parts.

Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel