Re: [Minios-devel] [UNIKRAFT PATCH 08/11] include/uk/list: fix style issues

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Hi,

I was thinking to keep the remaining style issues, but I guess you are
right, this can be fixed without hurting readability.

- Yuri.

Sharan Santhanam <sharan.santhanam@xxxxxxxxx> writes:

> Hello Yuri,
>
> There are some more formatting issues in the list.h
>
> git diff HEAD~4 HEAD | ./support/scripts/checkpatch
> .pl
> ERROR: Macros with complex values should be enclosed in parentheses
> #203: FILE: include/uk/list.h:134:
> +#define        uk_list_safe_reset_next(ptr, n, member) \
> +       (n) = uk_list_next_entry(ptr, member)
>
> ERROR: Macros with complex values should be enclosed in parentheses
> #409: FILE: include/uk/list.h:268:
> +#define        UK_INIT_HLIST_HEAD(head) (head)->first = NULL
>
> WARNING: line over 80 characters
> #580: FILE: include/uk/list.h:395:
> +            pos = uk_hlist_entry_safe((pos)->member.next, 
> typeof(*(pos)), member))
>
> WARNING: line over 80 characters
> #585: FILE: include/uk/list.h:398:
> +       for (pos = uk_hlist_entry_safe((pos)->member.next, 
> typeof(*(pos)), member); \
>
> WARNING: line over 80 characters
> #588: FILE: include/uk/list.h:400:
> +            pos = uk_hlist_entry_safe((pos)->member.next, 
> typeof(*(pos)), member))
>
> WARNING: line over 80 characters
> #595: FILE: include/uk/list.h:404:
> +            pos = uk_hlist_entry_safe((pos)->member.next, 
> typeof(*(pos)), member))
>
> total: 2 errors, 4 warnings, 604 lines checked
>
> Thanks & Regards
> Sharan


-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel