Re: [Minios-devel] [UNIKRAFT PATCH v2 2/3] build: `print-vars` target is a `null_targets`

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Simon,

This patch seems fine but the print-vars rule report the following error.

build_cmd_fixdep=       @printf '  %-7s %s\n' ''  '' &&
        @ Unikraft_Review/test/build/kconfig/fixdep ..d  '' 
Unikraft_Review/test/build    >  && rm -f ..d (       $(call 
build_cmd,$1,$2,$3,$4)
        $Q $(UK_FIXDEP) $(call tmp_depfile,$3) $3 '$(call strip,$4)' 
$(BUILD_DIR)       > $(call out2dep,$3) && $(RM) $(call tmp_depfile,$3))
Makefile:695: *** : missing build rule for source type .  Stop.


Since this bug is not related to this fix, we should fix it in a 
different patch.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan


On 1/31/19 12:12 PM, Simon Kuenzer wrote:
> Include the `print-vars` target to the `null_targets` variable. This
> is done for consistency.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>   Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 08ee2152..57567c1a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -139,7 +139,7 @@ export CONFIG_UK_NAME ?= $(notdir $(APP_DIR))
>   export DATE := $(shell date +%Y%m%d)
>   
>   # Makefile targets
> -null_targets           := print-version help
> +null_targets           := print-version print-vars help
>   noconfig_targets      := menuconfig nconfig gconfig xconfig config oldconfig 
> randconfig \
>                            defconfig %_defconfig allyesconfig allnoconfig 
> silentoldconfig release \
>                            olddefconfig properclean distclean $(null_targets)
> @@ -371,7 +371,7 @@ export UK_FAMILY ?= $(shell echo "$(CONFIG_UK_ARCH)" | \
>   
>   
>   # Quick-check if architecture exists
> -ifeq ($(filter $(null_targets) print-vars,$(MAKECMDGOALS)),)
> +ifeq ($(filter $(null_targets),$(MAKECMDGOALS)),)
>   ifeq ($(wildcard $(CONFIG_UK_BASE)/arch/$(UK_FAMILY)/$(ARCH)/Makefile.uk),)
>   $(error Target architecture ($(ARCH)) is currently not supported (could not 
> find $(CONFIG_UK_BASE)/arch/$(UK_FAMILY)/$(ARCH)/Makefile.uk).)
>   endif
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel