[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH 1/2] build: limit gcc version to 6.1 if LTO is enabled



Hello Yuri,

This patch seems fine.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

On 1/4/19 5:17 PM, Yuri Volchkov wrote:
Unikraft is using incremental linking, which is not supported by lto
in gcc earlier then 6.1.

Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
---
  Makefile | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/Makefile b/Makefile
index efc94a1..abb4e03 100644
--- a/Makefile
+++ b/Makefile
@@ -474,6 +474,12 @@ ifneq ($(CONFIG_HAVE_BOOTENTRY),y)
  $(error You did not select a library that handles bootstrapping! (e.g., 
ukboot))
  endif
+ifeq ($(CONFIG_OPTIMIZE_LTO), y)
+ifneq ($(call gcc_version_ge,6,1),y)
+$(error Your gcc version does not support incremental link time optimisation)
+endif
+endif
+
  # Generate build rules
  include $(CONFIG_UK_BASE)/support/build/Makefile.build

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.