Re: [Minios-devel] [UNIKRAFT PATCH v2 03/23] lib/nolibc: adapt mount.h to Unikraft

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Hi,

that checkpatch warning was left in place intentionally. The 80
characters are strongly suggested, but not sacred. I think here
splitting the line would hurt more then help.

Cheers,
-Yuri.

Sharan Santhanam <sharan.santhanam@xxxxxxxxx> writes:

> Hello yuri,
>
> This patch seems fine. There is checkpatch warning
>
>
> On line 55,
> WARNING: line over 80 characters
> #55: FILE: lib/nolibc/include/sys/mount.h:55:
> +#define MS_RMT_MASK 
> (MS_RDONLY|MS_SYNCHRONOUS|MS_MANDLOCK|MS_I_VERSION|MS_LAZYTIME)
>
>
> We can fix it while upstreaming.
>
>
>
> Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
>
> Thanks & Regards
> Sharan
>
>
> On 2/4/19 3:36 PM, Yuri Volchkov wrote:
>> Style problems and proper includes
>> 
>> Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
>> ---
>>   lib/nolibc/include/sys/mount.h | 38 +++++++++++++++++-----------------
>>   1 file changed, 19 insertions(+), 19 deletions(-)
>> 
>> diff --git a/lib/nolibc/include/sys/mount.h b/lib/nolibc/include/sys/mount.h
>> index 57a89c09..af855d69 100644
>> --- a/lib/nolibc/include/sys/mount.h
>> +++ b/lib/nolibc/include/sys/mount.h
>> @@ -5,23 +5,22 @@
>>   extern "C" {
>>   #endif
>>   
>> -#include <sys/ioctl.h>
>>   
>> -#define BLKROSET   _IO(0x12, 93)
>> -#define BLKROGET   _IO(0x12, 94)
>> -#define BLKRRPART  _IO(0x12, 95)
>> -#define BLKGETSIZE _IO(0x12, 96)
>> -#define BLKFLSBUF  _IO(0x12, 97)
>> -#define BLKRASET   _IO(0x12, 98)
>> -#define BLKRAGET   _IO(0x12, 99)
>> -#define BLKFRASET  _IO(0x12,100)
>> -#define BLKFRAGET  _IO(0x12,101)
>> -#define BLKSECTSET _IO(0x12,102)
>> -#define BLKSECTGET _IO(0x12,103)
>> -#define BLKSSZGET  _IO(0x12,104)
>> -#define BLKBSZGET  _IOR(0x12,112,size_t)
>> -#define BLKBSZSET  _IOW(0x12,113,size_t)
>> -#define BLKGETSIZE64 _IOR(0x12,114,size_t)
>> +#define BLKROSET      _IO(0x12,  93)
>> +#define BLKROGET      _IO(0x12,  94)
>> +#define BLKRRPART     _IO(0x12,  95)
>> +#define BLKGETSIZE    _IO(0x12,  96)
>> +#define BLKFLSBUF     _IO(0x12,  97)
>> +#define BLKRASET      _IO(0x12,  98)
>> +#define BLKRAGET      _IO(0x12,  99)
>> +#define BLKFRASET     _IO(0x12, 100)
>> +#define BLKFRAGET     _IO(0x12, 101)
>> +#define BLKSECTSET    _IO(0x12, 102)
>> +#define BLKSECTGET    _IO(0x12, 103)
>> +#define BLKSSZGET     _IO(0x12, 104)
>> +#define BLKBSZGET    _IOR(0x12, 112, size_t)
>> +#define BLKBSZSET    _IOW(0x12, 113, size_t)
>> +#define BLKGETSIZE64 _IOR(0x12, 114, size_t)
>>   
>>   #define MS_RDONLY      1
>>   #define MS_NOSUID      2
>> @@ -63,9 +62,10 @@ extern "C" {
>>   #define MNT_EXPIRE      4
>>   #define UMOUNT_NOFOLLOW 8
>>   
>> -int mount(const char *, const char *, const char *, unsigned long, const 
>> void *);
>> -int umount(const char *);
>> -int umount2(const char *, int);
>> +int mount(const char *dev, const char *dir, const char *fsname,
>> +      unsigned long flags, const void *data);
>> +int umount(const char *path);
>> +int umount2(const char *path, int flags);
>>   
>>   #ifdef __cplusplus
>>   }
>> 

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel