Re: [Minios-devel] [UNIKRAFT PATCH v2 01/23] include/uk: introduce __weak_alias macro

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Hi,

ah, that's what you mean. I added a note in the v3, which I just sent

Regards,
- Yuri.

Sharan Santhanam <sharan.santhanam@xxxxxxxxx> writes:

> Hello Yuri,
>
> Please find the comment inline.
>
> Thanks & Regards
> Sharan
>
>
> On 2/6/19 5:27 PM, Yuri Volchkov wrote:
>> Hi,
>> 
>> well, this is not a correct behavior of gcc. I don't like the idea of
>> polluting build log with warnings about not your problem and which you
>> can not fix. And I don't like the idea of ditching something as
>> essential as weak aliasing.
> I agree.
>
>> 
>> Another thing, LTO resolves a weak symbol only if it is referenced
>> inside a library. This is exactly the idea behind the workaround for
>> this "multiple definition of `main'" patch you reviewed earlier
>> today. Yes you could perhaps check if this is the case, and produce the
>> warning only if 1) LTO is enabled 2) the weak symbol is referenced
>> inside the library it was defined. I think this is way too complex for
>> the outcome.
> I was referring to the use case where the function is used within the 
> library. I was more in favor of adding a code-comment with a "NOTE:"
> mentioning about the bug. Just to remind us of this bug in LTO.
>
>> 

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel