Re: [Minios-devel] [UNIKRAFT PATCH] lib/ukboot: include uk/essentials.h in weak_main

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Oh yes, right. Even '__unused' shouldn't be available without this include.
Thanks!

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 12.02.19, 23:27, "Minios-devel on behalf of Yuri Volchkov" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
yuri.volchkov@xxxxxxxxx> wrote:

    In case of compiling with newlib enabled, essentials.h is not getting
    included. Because of that, compiler does not know what '__weak' means,
    and the compilation fails. Let's include essentials.h explicitly.
    
    Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
    ---
     lib/ukboot/weak_main.c | 1 +
     1 file changed, 1 insertion(+)
    
    diff --git a/lib/ukboot/weak_main.c b/lib/ukboot/weak_main.c
    index 697720c..deae3db 100644
    --- a/lib/ukboot/weak_main.c
    +++ b/lib/ukboot/weak_main.c
    @@ -1,5 +1,6 @@
     #include <stdio.h>
     #include <errno.h>
    +#include <uk/essentials.h>
     
     /* Internal main */
     int __weak main(int argc __unused, char *argv[] __unused)
    -- 
    2.19.2
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel