Re: [Minios-devel] [UNIKRAFT PATCHv5 04/23] plat: Clean up kernel image symbols

["Justin He (Arm Technology China)" <Justin.He@xxxxxxx>]

Hi Sharan

> -----Original Message-----
> From: Minios-devel <minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf
> Of Sharan Santhanam
> Sent: 2019年2月20日 19:50
> To: minios-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [Minios-devel] [UNIKRAFT PATCHv5 04/23] plat: Clean up kernel
> image symbols
>
> Hello Jia He,
>
> Please find the comments inline. This patch does not compile on xen
> platform for x86. Fails with the following error:
>
> In file included from
> /mnt/filesystems/roaming/workspace/Project/Unikraft_Review/Unikraft/pla
> t/xen/include/xen-x86/mm.h:46:0,
>                   from
> /mnt/filesystems/roaming/workspace/Project/Unikraft_Review/Unikraft/pla
> t/xen/io.c:37:
> /mnt/filesystems/roaming/workspace/Project/Unikraft_Review/Unikraft/pla
> t/xen/io.c:
> In function ‘ukplat_virt_to_phys’:
> /mnt/filesystems/roaming/workspace/Project/Unikraft_Review/Unikraft/pla
> t/xen/include/xen-x86/mm.h:243:55:
> error: invalid operands to binary - (have ‘long unsigned int’ and ‘char *’)
>   #define to_phys(x)                 ((unsigned long)(x)-VIRT_START)
>
> Please find inline the possible fix.

Thanks, this fix works. I verified it on x86 xen plat
Cheers,
Justin (Jia He)
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel