Re: [Minios-devel] [UNIKRAFT PATCHv6 04/23] plat: Clean up kernel image symbols

["Justin He (Arm Technology China)" <Justin.He@xxxxxxx>]

Hi Sharan

> -----Original Message-----
> From: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
> Sent: 2019年2月27日 18:41
> To: Justin He (Arm Technology China) <Justin.He@xxxxxxx>; minios-
> devel@xxxxxxxxxxxxxxxxxxxx; Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> Cc: Florian Schmidt <florian.schmidt@xxxxxxxxx>; Felipe Huici
> <felipe.huici@xxxxxxxxx>; Julien Grall <Julien.Grall@xxxxxxx>;
> yuri.volchkov@xxxxxxxxx; Kaly Xin (Arm Technology China) <Kaly.Xin@xxxxxxx>;
> Wei Chen (Arm Technology China) <Wei.Chen@xxxxxxx>
> Subject: Re: [UNIKRAFT PATCHv6 04/23] plat: Clean up kernel image symbols
>
> Hello Jia He,
>
> Please find a comment inline.
>
> Thanks & Regards
> Sharan
>
> On 2/22/19 7:21 AM, Jia He wrote:
> > From: Wei Chen <wei.chen@xxxxxxx>
> > There is a potential undefined behaviour for pointer comparision.
> > How to avoid this gcc optimization is under discussing. Since it
> > -       if (mem_base > (uint64_t)&_text)
>
> Redundant type conversion.

Yes, will remove it in next version after I resolve the tab -> space converting 
issue.

Thanks
--
Cheers,
Justin (Jia He)


> > +       if (mem_base > (unsigned long)__TEXT)
> >                  UK_CRASH("Fatal: Image outside of RAM\n");
> >
> >          max_addr = mem_base + mem_size;
> > -       _libkvmplat_pagetable =(void *) ALIGN_DOWN((size_t)&_end,
[...]
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel