Re: [Minios-devel] [UNIKRAFT PATCH] lib/nolibc: add definition for pid_t

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Hi,

looks good to me.

Reviewed-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>

Cheers, Yuri.

Florian Schmidt <florian.schmidt@xxxxxxxxx> writes:

> Some headers already defined __NEED_pid_t, but the actual definition in
> shareddefs.h didn't make it in. Fix that.
>
> Using int for pid_t follows the typedef in musl, from which the code was
> imported that had the __NEED_pid_t defines.
>
> Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
> ---
>  lib/nolibc/include/nolibc-internal/shareddefs.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/lib/nolibc/include/nolibc-internal/shareddefs.h 
> b/lib/nolibc/include/nolibc-internal/shareddefs.h
> index 7572e2d3..62f45a3d 100644
> --- a/lib/nolibc/include/nolibc-internal/shareddefs.h
> +++ b/lib/nolibc/include/nolibc-internal/shareddefs.h
> @@ -106,6 +106,11 @@ typedef unsigned gid_t;
>  #define __DEFINED_gid_t
>  #endif
>  
> +#if defined(__NEED_pid_t) && !defined(__DEFINED_pid_t)
> +typedef int pid_t;
> +#define __DEFINED_pid_t
> +#endif
> +
>  #if defined(__NEED_dev_t) && !defined(__DEFINED_dev_t)
>  typedef __u64 dev_t;
>  #define __DEFINED_dev_t
> -- 
> 2.21.0
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel