Re: [Minios-devel] [UNIKRAFT PATCHv2 2/8] lib/fdt: Introduce a helper of fdt_get_cells

[Jia He <jiakernel2@xxxxxxxxx>]

On 2019/3/11 18:59, Julien Grall wrote:
> Hi,
>
> On 11/03/2019 09:14, Jia He wrote:
> > From: Wei Chen <wei.chen@xxxxxxx>
> > In device tree, we always use fdt_address_cells, fdt_size_cells
> > and fdt_interrupt_cells to get cells' size. fdt_get_cells will
> > reduce the redundant code for this *_cells APIs.
> > If fdt_get_cells could not find the property in current node,
> > in previous implement, it will return 2 arbitrarily. In this patch
> > it will try to find the property in parent node.
> This patch is actually introducing fdt_get_cells. So which previous 
> implementation are you talking about?
> Also, 2 is not arbitrary, this is based on the spec (see 2.3.5 in 
> [1]). Although, technically for #size-cells, you should return 1 here.
Yes, will make the return value different btw address-cells and #size-cells

Thanks


> > Jira: ENTOS-860
> What is it for?
yes :)

---
Cheers,
Justin (Jia He)



_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel