Re: [Minios-devel] [UNIKRAFT PATCH 7/7] lib/nolibc: Implement clock_gettime()

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Felipe,

thanks for the reviews!

On 3/13/19 4:36 PM, Felipe Huici wrote:
> > On 22. Feb 2019, at 15:12, Florian Schmidt <Florian.Schmidt@xxxxxxxxx> wrote:
> > diff --git a/lib/nolibc/include/time.h b/lib/nolibc/include/time.h
> > index a6b9585b..5223914a 100644
> > --- a/lib/nolibc/include/time.h
> > +++ b/lib/nolibc/include/time.h
> > @@ -44,14 +44,21 @@ extern "C" {
> > #define __NEED_NULL
> > #define __NEED_time_t
> > #define __NEED_struct_timespec
> > +#define __NEED_clockid_t
> > #include <nolibc-internal/shareddefs.h>
> >
> > +#define CLOCK_REALTIME  0
> > +#define CLOCK_MONOTONIC 1
> > +
> > +#define TIMER_ABSTIME 1
> The line above defines TIMER_ABSTIME but it’s never used. I’ll remove this line 
> on upstreaming.
Whoops, yeah, that's an unrelated leftover that doesn't belong to this 
patch series.
Cheers,
Florian

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel