[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCHv3 1/6] plat/common: Introduce fdt_getprop_u32_by_offset helper



Hi,

On 3/21/19 8:05 AM, Jia He wrote:
From: Jianyong Wu <jianyong.wu@xxxxxxx>
This helper will be used very frequently to u32 from properties.
So we provide this helper here to avoid using fdt_getprop and
fdt32_to_cpu everywhere.

Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
Signed-off-by: Jianyong Wu <jianyong.wu@xxxxxxx>
Signed-off-by: Jia He <justin.he@xxxxxxx>
---
  plat/common/arm/irq_fdt.c         | 57 +++++++++++++++++++++++++++++++

Why did you prefix with irq? What actually prevents those helpers in other drivers that may not have interrupt?

Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.