Re: [Minios-devel] [UNIKRAFT PATCH 1/1] build: fix build rules that expect directories

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Looks good! Thanks.

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 06.03.19, 11:04, "Florian Schmidt" <Florian.Schmidt@xxxxxxxxx> wrote:

    These two rules running during the prepare step expect build/kconfig/ to
    exist. This happens to be the case make -j1, because another rule
    creates that directory before make gets to those rules. That breaks on
    parallel make though, so make sure the directory is there regardless of
    rule execution order.
    
    Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
    ---
     Makefile | 2 ++
     1 file changed, 2 insertions(+)
    
    diff --git a/Makefile b/Makefile
    index 8e81c64b..2588d261 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -574,6 +574,7 @@ $(KCONFIG_APP_IN) $(KCONFIG_ELIB_IN): %: %.new
        @cmp -s $^ $@; if [ $$? -ne 0 ]; then cp $^ $@; fi
     
     $(KCONFIG_APP_IN).new:
    +   mkdir -p $(@D)
        @echo '# external application' > $@
     ifneq ($(CONFIG_UK_BASE),$(CONFIG_UK_APP))
        @echo 'source "$(APP_DIR)/Config.uk"' >> $@
    @@ -583,6 +584,7 @@ endif
     
     # auto-generated KConfig files for including external libraries
     $(KCONFIG_ELIB_IN).new:
    +   mkdir -p $(@D)
        @echo '# external libraries' > $@
        @$(foreach E,$(ELIB_DIR), \
                echo 'source "$(E)/Config.uk"' >> $@; \
    -- 
    2.21.0
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel