[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH] support/build: disable make built-in rules


  • To: Felipe Huici <Felipe.Huici@xxxxxxxxx>, "minios-devel@xxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxx>
  • From: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
  • Date: Fri, 29 Mar 2019 14:34:06 +0000
  • Accept-language: en-GB, gl-ES, de-DE, en-US
  • Delivery-date: Fri, 29 Mar 2019 14:34:13 +0000
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>
  • Thread-index: AQHU4LPC/U6+9KY9HEKTgHtgSASJtqYit4UA
  • Thread-topic: [Minios-devel] [UNIKRAFT PATCH] support/build: disable make built-in rules

Thanks a lot! This solves a number of unexpected behaviors.

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>


On 22.03.19, 14:32, "Minios-devel on behalf of Felipe Huici" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of felipe.huici@xxxxxxxxx> 
wrote:

    When adding an externally-built object file to the Unikraft build via
    [LIBNAME]_OBJS, the make built-in rule would try to recompile the
    object file from source and would fail. This patch disables make's
    built-in rules so the build works as intended.
    
    Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
    ---
     Makefile | 3 +++
     1 file changed, 3 insertions(+)
    
    diff --git a/Makefile b/Makefile
    index 7f29e006..9452e80c 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -37,6 +37,9 @@ else # umask
     .PHONY: all
     all:
     
    +# Disable built-in rules
    +.SUFFIXES:
    +
     # Save running make version
     RUNNING_MAKE_VERSION := $(MAKE_VERSION)
     
    -- 
    2.11.0
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.