[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH 1/2] plat/kvm: Split virtio-net from the virtio library


  • To: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>, minios-devel@xxxxxxxxxxxxx
  • From: Costin Lupu <costin.lupu@xxxxxxxxx>
  • Date: Tue, 2 Apr 2019 13:20:21 +0300
  • Delivery-date: Tue, 02 Apr 2019 10:20:31 +0000
  • Ironport-phdr: 9a23:+RnUNRyXJU6w+/HXCy+O+j09IxM/srCxBDY+r6Qd2u8XIJqq85mqBkHD//Il1AaPAdyCraocwLKJ++C4ACpcuM7H6ChDOLV3FDY9wf0MmAIhBMPXQWbaF9XNKxIAIcJZSVV+9Gu6O0UGUOz3ZlnVv2HgpWVKQka3OgV6PPn6FZDPhMqrye+y54fTYwJVjzahfL9+Nhq7oRjMusUMnYduNqk9xgfLr3BVf+ha2X5kKUickhrh+su85oJv/zhVt/k868NOTKL2crgiQ7dFFjomKWc15MPqtRnHUwSC42YXX3sVnBRVHQXL9Qn2UZjtvCT0sOp9wzSaMtbtTb8oQzSi7rxkRwHuhSwaKjM26mDXish3jKJGvBKsogF0zoDIbI2JMvd1Y7jQds0GS2VfQslRVjRBAoKiYIsJE+oBJvtTo43kq1cTsReyGQygCeXywTFKm3D2x7U33fk/HwHI3AIuHNwAv3rbo9r3KKgcXvu4zLXKwDjZc/9axTnw5YrOfxs8of+MR7Vwcc/JxEQxEAPFlUmQqY3jPziI0OoNrnCb7/d9Xu+ol2EnrBpxoiSuxscqkIXJgp8VykjZ9Shi3Ik1Pse0SFZmYdG/CpdQrSaaOpJwT8g/QG9ooD43xqAJtJKmZiQHy5QqywTBZ/CZcYWE+BzuWP6MLTp3mX5pYrGyihao/US+xODxWNO43EtFoyZblNTHq2oD2AbJ6sedT/tw5kKh2TGS2A/N8uxEOkU0lbbDK54m374wioIfsUTdES/yn0X7lLGWdkA+9eip7+TreKnppoSGO49slwHxKb4imta4AeggMwgOWXaU+fik2bH+8kD1Xa9Gg/42n6XDrpzWO8YWqrS3DgNN14Ys8Re/DzOo0NQCmnkHKUpIdw6Aj4jyJ1HOIfb4Ae27g1SxiDdr2uvLMaH6ApnXNnjDjazucaxn605b0AYz18xQ54pICrEdJ/L+QkrxtN3eDh84NAy02P/rB8hj2YMAR22PBrSUMKfTsV+T+uIvOPOAZYALtzb7MfQl4OTujXAhk18HYaapxYcXaGy/Hvl+OEWZYWDjgs0bHmcMpAY+V/bliFueUT5TfXmyWbgz5jQgBYKgE4jMWoStj6aa0yuhAJJWezMONlfZKnfhbYyCE8wFbj6SK8lol3RQTrioUYYnkwqnshP6wrxuK8LS9yYcvJil2cUjo6XWlBcz8icxA8mD3mWlS2BvgnhOVzIwmqdlrh9T0FCGhIN/mOBZE5R3+utUGlMxMoXAzuo8D83qRyrKZZGRVVzgWNLwUmJ5dc4439JbOxU1IN6llB2WmnPyW7I=
  • Ironport-sdr: zajAkx/jt9fD+jenCYUfcVL6Brp6jhh/mkERV7U41InOWz4EOTBkCVSFnaqF7sS3wbhWmRR890 PvhcnWPJvgXg==
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>

Hi Sharan,

Thanks for the patch! I tested it, it works!

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 4/1/19 4:04 PM, Sharan Santhanam wrote:
> We add this patch to split virtio-net device from the virtio bus
> library.
> 
> Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
> ---
>  plat/kvm/Makefile.uk | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/plat/kvm/Makefile.uk b/plat/kvm/Makefile.uk
> index 8242983..2906f53 100644
> --- a/plat/kvm/Makefile.uk
> +++ b/plat/kvm/Makefile.uk
> @@ -9,6 +9,7 @@ $(eval $(call addplat_s,kvm,$(CONFIG_PLAT_KVM)))
>  $(eval $(call addplatlib,kvm,libkvmplat))
>  $(eval $(call addplatlib_s,kvm,libkvmpci,$(CONFIG_KVM_PCI)))
>  $(eval $(call addplatlib_s,kvm,libkvmvirtio,$(CONFIG_VIRTIO_BUS)))
> +$(eval $(call addplatlib_s,kvm,libkvmvirtionet,$(CONFIG_VIRTIO_NET)))
>  
>  ##
>  ## Platform library definitions
> @@ -102,5 +103,14 @@ LIBKVMVIRTIO_SRCS-$(CONFIG_VIRTIO_BUS) +=\
>                                                       
> $(UK_PLAT_DRIVERS_BASE)/virtio/virtio_ring.c
>  LIBKVMVIRTIO_SRCS-$(CONFIG_VIRTIO_PCI) +=\
>                                                       
> $(UK_PLAT_DRIVERS_BASE)/virtio/virtio_pci.c
> -LIBKVMVIRTIO_SRCS-$(CONFIG_VIRTIO_NET) +=\
> -                                                     
> $(UK_PLAT_DRIVERS_BASE)/virtio/virtio_net.c
> +##
> +## Virtio Net library definition
> +##
> +LIBKVMVIRTIONET_ASINCLUDES-y   += -I$(LIBKVMPLAT_BASE)/include
> +LIBKVMVIRTIONET_CINCLUDES-y    += -I$(LIBKVMPLAT_BASE)/include
> +LIBKVMVIRTIONET_ASINCLUDES-y   += -I$(UK_PLAT_COMMON_BASE)/include
> +LIBKVMVIRTIONET_CINCLUDES-y    += -I$(UK_PLAT_COMMON_BASE)/include
> +LIBKVMVIRTIONET_ASINCLUDES-y   += -I$(UK_PLAT_DRIVERS_BASE)/include
> +LIBKVMVIRTIONET_CINCLUDES-y    += -I$(UK_PLAT_DRIVERS_BASE)/include
> +LIBKVMVIRTIONET_SRCS-y +=\
> +                     $(UK_PLAT_DRIVERS_BASE)/virtio/virtio_net.c
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.