Re: [Minios-devel] [UNIKRAFT PATCHv4 1/9] plat/common: Introduce fdt_getprop_u32_by_offset helper

[Jia He <jiakernel2@xxxxxxxxx>]

Hi Sharan, one more question is as below:

On 2019/4/8 17:20, Sharan Santhanam wrote:
> Hello Jia He,
>
> On 4/8/19 4:59 AM, Jia He wrote:
> > Hi Sharan
> >
> > On 2019/4/4 21:32, Sharan Santhanam wrote:
> > > Hello,
> > >
> > > Please find the review comments inline.
[...]

> > > There are multiple fdt.h with a similar path. The "fdt.h" from the library 
> > > gets preference because of the order include. We should try and avoid such 
> > > situation.
> > >  1. lib/fdt/include/fdt.h
> > >
> > >  2. plat/common/include/fdt.h
> > Yes, agreed. How about plat/common/include/uk_fdt.h?
> How about
> plat/driver/include/ofw/fdt.h and the implementation needed in plat/driver/ofw/
further more, is exportsyms.uk still needed after I move .c .h to 
plat/drivers/ofw?

---
Cheers,
Justin (Jia He)


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel