Re: [Minios-devel] [UNIKRAFT PATCHv4 1/9] plat/common: Introduce fdt_getprop_u32_by_offset helper

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Jia He,



On 4/9/19 9:25 AM, Jia He wrote:
> Hi Sharan
>
> On 2019/4/4 21:32, Sharan Santhanam wrote:
> > Hello,
> >
> > Please find the review comments inline.
> >
> > Thanks & Regards
> > Sharan
> [...]
> > Prefer to use <> instead of the "" for print.h.
> > > +#include "uk/print.h"
> > > +
> > > +int fdt_getprop_u32_by_offset(const void *fdt, int offset,
> > > +        const char *name, uint32_t *out)
> > > +{
> > > +    const fdt32_t *prop;
> > > +    int prop_len;
> > > +
> > UK_ASSERT(out); or you can report an error?
> >
> > We can call the fdt_get_property_namelen directly as it rest of the 
> > functions.
> I am not sure I understand the comments well.
>
> fdt_getprop is a wrap function of fdt_get_property_namelen. Why should we
>
> call fdt_get_property_namelen directly here?
I suggested using the fdt_get_property_namelen directly because all the 
fdt_get_property* functions uses fdt_get_property_namelen directly. We 
could use the similar principle and the function was library global. It 
is more a suggestion. If adds more problem we could drop it.


> Thanks for the clarification
>
>
> ---
> Cheers,
> Justin (Jia He)
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel
Thanks & Regards
Sharan

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel