Re: [Minios-devel] [UNIKRAFT PATCH] build: Use `mk_sub_build_dir` for Kconfig build directories

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Simon,

Looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

============================================================
Dr. Felipe Huici
Chief Researcher, Systems and Machine Learning Group
NEC Laboratories Europe GmbH
Kurfuerstenanlage 36, D-69115 Heidelberg
Tel.  +49
(0)6221 4342-241
Fax:  +49
(0)6221 4342-155
 
e-mail:
felipe.huici@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

On 10.04.19, 15:51, "Minios-devel on behalf of Simon Kuenzer" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
simon.kuenzer@xxxxxxxxx> wrote:

    This commit implements patch f897e6d8 with `mk_sub_build_dir`
    instead. This change makes the way of creating the `kconfig`
    directory inline with the creation of `include` and `include/uk`
    build directories.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     Makefile | 5 ++---
     1 file changed, 2 insertions(+), 3 deletions(-)
    
    diff --git a/Makefile b/Makefile
    index b2219a7d..f0d1ad47 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -464,7 +464,8 @@ ASFLAGS         += -DCC_VERSION=$(CC_VERSION)
     CFLAGS             += -DCC_VERSION=$(CC_VERSION)
     CXXFLAGS   += -DCC_VERSION=$(CC_VERSION)
     
    -# ensure $(BUILD_DIR)/include and $(BUILD_DIR)/include/uk exists
    +# ensure $(BUILD_DIR)/kconfig, $(BUILD_DIR)/include and 
$(BUILD_DIR)/include/uk exists
    +$(call mk_sub_build_dir,kconfig)
     $(call mk_sub_build_dir,include)
     $(call mk_sub_build_dir,include/uk)
     
    @@ -581,7 +582,6 @@ $(KCONFIG_APP_IN) $(KCONFIG_ELIB_IN): %: %.new
        @cmp -s $^ $@; if [ $$? -ne 0 ]; then cp $^ $@; fi
     
     $(KCONFIG_APP_IN).new:
    -   mkdir -p $(@D)
        @echo '# external application' > $@
     ifneq ($(CONFIG_UK_BASE),$(CONFIG_UK_APP))
        @echo 'source "$(APP_DIR)/Config.uk"' >> $@
    @@ -591,7 +591,6 @@ endif
     
     # auto-generated KConfig files for including external libraries
     $(KCONFIG_ELIB_IN).new:
    -   mkdir -p $(@D)
        @echo '# external libraries' > $@
        @$(foreach E,$(ELIB_DIR), \
                echo 'source "$(E)/Config.uk"' >> $@; \
    -- 
    2.21.0
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel