Re: [Minios-devel] [UNIKRAFT PATCHv2 0/7] Implement Arm64 timer APIs for scheduler

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 4/18/19 9:06 AM, Jia He wrote:
> Currently, the timer library only provides some simple functions for
> unikraft to print timestamp. But it's not enough for scheduler. In
> this series, we implemented generic_timer_cpu_block and timer interrupt
> for scheduler to sleep and wakeup.
>
> Changes:
> v1->v2: no functional changes, just rebase due to the changes of series
>         2 and 3. I haven't address Julien's comments at [1] for further
>         discusstion.
My two point in that thread stands
        1) The nop() looks unnecessary
        2) You need to come up with an explanation for the 4000ns delta

Cheers,

> [1]https://lists.xenproject.org/archives/html/minios-devel/2018-12/msg00129.html
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel