[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Minios-devel] [UNIKRAFT PATCH 2/8] lib/uksched: Do not reset sched attribute on thread removal


  • To: minios-devel@xxxxxxxxxxxxx
  • From: Costin Lupu <costin.lupu@xxxxxxxxx>
  • Date: Tue, 23 Apr 2019 13:41:38 +0300
  • Cc: felipe.huici@xxxxxxxxx, Florian.Schmidt@xxxxxxxxx, simon.kuenzer@xxxxxxxxx, yuri.volchkov@xxxxxxxxx, sharan.santhanam@xxxxxxxxx
  • Delivery-date: Tue, 23 Apr 2019 10:42:02 +0000
  • Ironport-phdr: 9a23:cXUA5RM4iNh5eE+s0LIl6mtUPXoX/o7sNwtQ0KIMzox0K/37oMbcNUDSrc9gkEXOFd2Cra4d0qyK4+u6ACRAuc/H7ClaNsQUFlcssoY/p0QYGsmLCEn2frbBThcRO4B8bmJj5GyxKkNPGczzNBX4q3y26iMOSF2kbVImbuv6FZTPgMupyuu854PcYxlShDq6fLh+MAi6oR/eu8ULnIduMKk8xxjGrndWZuhd2GdkKU6Okxrm6cq84YJv/z5Mt/498sJLTLn3cbk/QbFEFjotLno75NfstRnNTAuP4mUTX2ALmRdWAAbL8Q/3UI7pviT1quRy1i+aPdbrTb8vQjSt871rSB7zhygZMTMy7XzahdZxjKJfpxKhugB/zovJa4ybKPZyYqXQds4cSGFcXMheSjZBD5u8YYUREuQPM+VWoY7/qFsAthayGRWgCfnzxjJSmnP6was32PkhHwHc2wwgGsoDvWrTrNXuKKcSUOa1x7TOwzXed/NWxCr25Y/UfRAmuvGMQbNwcczLxUkrCgPFlkiQpJf5MDOOzOgNq3Wb4PF6WeK1jG4qsgd8qSWsyMc0koTFm40Yxk3e+Sh6wIs5P8O0RFB5bNK+HpZcrzyWOoRrTs84QGxluDw2xqMItJO1ZiQG1ZsqywDZZveaaYaH+AjjW/yUITpggXJlf6+wiAiq/Ei7z+38StG00FFXripZitXMtm4C1xjU6sWfVPt9+12u2TeL1wzJ9u5EOlo4lbLGK5E62LIwjJ0TvVzCHi/whkr2kLebelgr9+S18ejqYbXrqoWCO4NqiAzyKKojltS6AesiMwgOW2ab+f671L3m5UD2XLJKjuYqkqnYtpDWP8AbprOhAw9IyYss9w2/Ay2+0NQFhnYLNkhFeBWfg4jzJ17OOOz4Deu4g1m0lTdrxvbGPrzmApXWN3TMjanufahj5E5Y0wczydFf54lICrEaOv7yVVH+tNrCAh8+KQy0zP7tCM9h2YMGRWKPHqiZPbvSv1+M4eIvOeiMa5UTuDrnNvYq+/7ujXo4mVAAYamkxp0XZ26kEfRiOUqWemDgjckcEW0SpAoxUPTqiEGeUT5Uf3uyUbwz5jU6CIK+E4jPXICtgKGA3CinH51bfWZGBU6QHnfsbYqLQO0AZzyPIsV5iDwLSaChS5M91RGprAL60LpnIfDO+iICs5LvzsN16PfVlREu9Tx7FcKd3HuIT2xvmGMHWSM53KRlrkNm0FuMz7V4ieRCFdNP//NJThs6NZnEwuxhCtDyXwXBftGTRFalX9WpHzcxT9MvzN8UeEt9HcutgQzH3yWwGLAZjaKEBIEs+KLGw3fxP9p9y2rB1KQ5j1gmX9FPNWy8iq5h8AjTA5LGk0Wal6ata6QRxyjN+3mfwmqKpk5XSxR8XrvYXSNXWkyDqNX/50TZCrOjF7kjGg9A0tKZbLtHbJvul1oVau3kPYH1ZHmtmmH4IQuQ2/vYZ43xZ2QbmiHAEFUsmBtV5WuMcxI5UHTy61nCBSBjQAq8K3jn9vNz/Su2
  • Ironport-sdr: Q2IKgDXAn8wxqngS6k1RWp4hjy4UE51Rvg2jXvBTJNn9sx3M3tTjOxBdeNDgRafKtFmi3/3AAh /1E7KFRfkuCA==
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>

Scheduler reference should be kept until destroying the thread,
basically during the entire life of the thread. uk_sched_thread_remove()
is always called before destroying the thread, therefore it must not
remove the scheduler reference from thread.

Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
---
 lib/uksched/include/uk/sched.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/uksched/include/uk/sched.h b/lib/uksched/include/uk/sched.h
index cc5fbe93..f9dc16d0 100644
--- a/lib/uksched/include/uk/sched.h
+++ b/lib/uksched/include/uk/sched.h
@@ -130,7 +130,6 @@ static inline int uk_sched_thread_remove(struct uk_sched *s,
        UK_ASSERT(t);
        UK_ASSERT(t->sched == s);
        s->thread_remove(s, t);
-       t->sched = NULL;
        return 0;
 }
 
-- 
2.11.0


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.