Re: [Minios-devel] [UNIKRAFT PATCH 1/2] lib/ukswrand: fix constructor priority definition

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Yuri,

Patch looks good, I might fix a few grammar things in the commit message on 
upstreaming.

Thanks,

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 18.04.19, 18:32, "Minios-devel on behalf of Yuri Volchkov" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
yuri.volchkov@xxxxxxxxx> wrote:

    The priority constant had parentheses. This constant is passed into
    UK_CTOR_FUNC, where parentheses are breaking the concatenations (##).
    
    Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
    ---
     lib/ukswrand/mwc.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/lib/ukswrand/mwc.c b/lib/ukswrand/mwc.c
    index 199247d3..39c3daaf 100644
    --- a/lib/ukswrand/mwc.c
    +++ b/lib/ukswrand/mwc.c
    @@ -40,7 +40,7 @@
     
     /* 
https://stackoverflow.com/questions/9492581/c-random-number-generation-pure-c-code-no-libraries-or-functions
 */
     #define PHI 0x9e3779b9
    -#define UK_SWRAND_CTOR_PRIO    (1)
    +#define UK_SWRAND_CTOR_PRIO    1
     
     struct uk_swrand uk_swrand_def;
     
    -- 
    2.19.2
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel