Re: [Minios-devel] [UNIKRAFT PATCH v2 3/8] include/plat: Add flags for initramdisk memory regions

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Simon,

This patch looks good.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

-- Felipe

On 09.05.19, 16:27, "Simon Kuenzer" <simon.kuenzer@xxxxxxxxx> wrote:

    Add region flags to specify memory regions that contain init
    modules (initramdisks).
    This patch also introduces documentation about the meaning of the
    individual flags.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     include/uk/plat/memory.h | 14 ++++++++++----
     1 file changed, 10 insertions(+), 4 deletions(-)
    
    diff --git a/include/uk/plat/memory.h b/include/uk/plat/memory.h
    index 51b1b234..bc979e12 100644
    --- a/include/uk/plat/memory.h
    +++ b/include/uk/plat/memory.h
    @@ -45,15 +45,21 @@ extern "C" {
     #endif
     
     /* Memory region flags */
    -#define UKPLAT_MEMRF_FREE        (0x1)
    -#define UKPLAT_MEMRF_RESERVED    (0x2)
    -#define UKPLAT_MEMRF_READABLE    (0x4)
    -#define UKPLAT_MEMRF_WRITABLE    (0x8)
    +#define UKPLAT_MEMRF_FREE  (0x1)   /* Region with uninitialized memory */
    +#define UKPLAT_MEMRF_RESERVED      (0x2)   /* Region is in use by platform 
*/
    +#define UKPLAT_MEMRF_EXTRADATA     (0x4)   /* Contains additional loaded 
data
    +                                    * (e.g., initramdisk)
    +                                    */
    +#define UKPLAT_MEMRF_READABLE      (0x10)  /* Region is readable */
    +#define UKPLAT_MEMRF_WRITABLE      (0x20)  /* Region is writable */
     
     #define UKPLAT_MEMRF_ALLOCATABLE (UKPLAT_MEMRF_FREE \
                                  | UKPLAT_MEMRF_READABLE \
                                  | UKPLAT_MEMRF_WRITABLE)
     
    +#define UKPLAT_MEMRF_INITRD      (UKPLAT_MEMRF_EXTRADATA \
    +                             | UKPLAT_MEMRF_READABLE)
    +
     /* Descriptor of a memory region */
     struct ukplat_memregion_desc {
        void *base;
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel