Re: [Minios-devel] [UNIKRAFT PATCH v2 3/5] lib/devfs: Tabify imported devfs code

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Reviewed-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>

"Vlad-Andrei BĂDOIU (78692)" <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
writes:

> According to Unikraft's coding style indents are
> under the form of tabs. The imported code used both
> spaces and tabs. This patch makes all indents to
> be use tabs.
>
> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
> ---
>  lib/devfs/devfs_vnops.c    |  6 +++---
>  lib/devfs/include/device.h | 38 +++++++++++++++++++-------------------
>  2 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/lib/devfs/devfs_vnops.c b/lib/devfs/devfs_vnops.c
> index 70987477..617ed359 100644
> --- a/lib/devfs/devfs_vnops.c
> +++ b/lib/devfs/devfs_vnops.c
> @@ -300,9 +300,9 @@ struct vfsops devfs_vfsops = {
>  };
>  
>  static struct vfscore_fs_type fs_devfs = {
> -    .vs_name = "devfs",
> -    .vs_init = NULL,
> -    .vs_op = &devfs_vfsops,
> +     .vs_name = "devfs",
> +     .vs_init = NULL,
> +     .vs_op = &devfs_vfsops,
>  };
>  
>  UK_FS_REGISTER(fs_devfs);
> diff --git a/lib/devfs/include/device.h b/lib/devfs/include/device.h
> index 95e247d8..90434b18 100644
> --- a/lib/devfs/include/device.h
> +++ b/lib/devfs/include/device.h
> @@ -102,13 +102,13 @@ struct driver {
>   */
>  
>  typedef enum device_state {
> -    DS_INACTIVE          = 0x00,             /* driver is inactive */
> -    DS_ALIVE     = 0x01,             /* probe succeded */
> -    DS_ACTIVE            = 0x02,             /* intialized */
> -    DS_DEBUG     = 0x04,             /* debug */
> -    DS_NOTPRESENT   = 0x08,     /* not probed or probe failed */
> -    DS_ATTACHING    = 0x10,     /* currently attaching */
> -    DS_ATTACHED     = 0x20,     /*attach method called */
> +     DS_INACTIVE         = 0x00,             /* driver is inactive */
> +     DS_ALIVE            = 0x01,             /* probe succeded */
> +     DS_ACTIVE           = 0x02,             /* intialized */
> +     DS_DEBUG            = 0x04,             /* debug */
> +     DS_NOTPRESENT   = 0x08,     /* not probed or probe failed */
> +     DS_ATTACHING    = 0x10,     /* currently attaching */
> +     DS_ATTACHED     = 0x20,     /*attach method called */
>  } device_state_t;
>  
>  /*
> @@ -181,24 +181,24 @@ static inline void device_quiet(device_t dev)
>  static inline const char *
>  devtoname(struct device *dev)
>  {
> -    return dev->name;
> +     return dev->name;
>  }
>  
> -int   device_open(const char *, int, struct device **);
> -int   device_close(struct device *);
> -int   device_read(struct device *, struct uio *, int);
> -int   device_write(struct device *, struct uio *, int);
> -int   device_ioctl(struct device *, unsigned long, void *);
> -int   device_info(struct devinfo *);
> +int device_open(const char *, int, struct device **);
> +int device_close(struct device *);
> +int device_read(struct device *, struct uio *, int);
> +int device_write(struct device *, struct uio *, int);
> +int device_ioctl(struct device *, unsigned long, void *);
> +int device_info(struct devinfo *);
>  
> -int   bdev_read(struct device *dev, struct uio *uio, int ioflags);
> -int   bdev_write(struct device *dev, struct uio *uio, int ioflags);
> +int bdev_read(struct device *dev, struct uio *uio, int ioflags);
> +int bdev_write(struct device *dev, struct uio *uio, int ioflags);
>  
> -int  enodev(void);
> -int  nullop(void);
> +int enodev(void);
> +int nullop(void);
>  void multiplex_strategy(struct bio *);
>  
> -int  physio(struct device *dev, struct uio *uio, int ioflags);
> +int physio(struct device *dev, struct uio *uio, int ioflags);
>  
>  struct device *      device_create(struct driver *drv, const char *name, int 
> flags);
>  int device_destroy(struct device *dev);
> -- 
> 2.21.0
>

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel