Re: [Minios-devel] [UNIKRAFT PATCH 3/8] lib/ukschedcoop: Enable library if uksched is enabled

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

This looks good. The only thing I noticed is that setting the "depends 
on" moves ukschedcoop from the main library menu and puts it into a new 
uksched submenu, so at first, I was confused where the option went. Then 
again, maybe that layout is actually better.
Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

On 4/23/19 12:41 PM, Costin Lupu wrote:
> Until now, enabling uksched did not enable ukschedcoop, which is the
> only scheduler implementation. This resulted in a critical error from
> Unikraft because no scheduler was registered. The current changes enable
> the cooperative scheduler as the default implementation when uksched is
> enabled.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   lib/ukschedcoop/Config.uk | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/ukschedcoop/Config.uk b/lib/ukschedcoop/Config.uk
> index 8a507251..6a0c1f5a 100644
> --- a/lib/ukschedcoop/Config.uk
> +++ b/lib/ukschedcoop/Config.uk
> @@ -1,4 +1,4 @@
>   config LIBUKSCHEDCOOP
>         bool "ukschedcoop: Cooperative Round-Robin scheduler"
> -       default n
> -       select LIBUKSCHED
> +       default y
> +       depends on LIBUKSCHED
--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel