Re: [Minios-devel] [UNIKRAFT PATCH v2 0/5] Enable solo5 platform support

["Haibo Xu (Arm Technology China)" <Haibo.Xu@xxxxxxx>]

Hi Simon,

Thanks for your comments here! I will sent out a new patch series soon.

Regards,
Haibo
On 2019/5/24 17:57, Simon Kuenzer wrote:
> Hi Haibo,
>
> you patch series looks really good. However, because Solo5 requires to 
> download the monitor code, I would prefer to put it as external platform 
> library. To make this work a sent a patch that adds support for this: 
> https://patchwork.unikraft.org/patch/735006/
>
> As follow-up: Can you create a v3 that applies to an empty repository. But 
> your sources to the base directory. This means do not create a solo5/ or 
> plat/solo5/ directory and put in there Config.uk, Makefile.uk, and Linker.uk. 
> Put this into the base (similar to the other external libraries we have). I 
> will create a new repository for this on xenbits where we can then upload the 
> solo5 patches.
>
> Please also have a look to my inlined comments to your patches.
>
> Thanks a lot,
>
> Simon
>
>
> On 19.03.19 11:31, Haibo Xu wrote:
>> Hi,
>>
>> As discussed with Simon and Ricardo in the email loop,
>> Solo5(formerly known as ukvm) would make most sense as
>> another and new platform library for the unikraft, this
>> patch set will try to enable the solo5 platform support.
>>
>> Currently, the implementation has been tested with the
>> hello-world application on both x86-64 and arm64 machine.
>>
>> v1->v2:
>>     - add a menu option to solo5 platform that enable
>>            build of solo5 monitor;
>>     - change the solo5 src codes download method, and
>>            use the unikraft build system "fetch" and "extract"
>>            method.
>>
>> Regards,
>>
>> Haibo
>>
>> Haibo Xu (5):
>>    plat/solo5: Add solo5 platform Config.uk file
>>    plat/solo5: Add solo5 platform link files.
>>    plat/solo5: Add solo5 platform Makefile.uk
>>    plat/solo5: Add the solo5 API declaration in solo5.h
>>    plat/solo5: Add platform interface implementation
>>
>>   plat/Config.uk                   |   1 +
>>   plat/Linker.uk                   |   1 +
>>   plat/Makefile.uk                 |   1 +
>>   plat/solo5/Config.uk             |  17 ++
>>   plat/solo5/Linker.uk             |  61 +++++++
>>   plat/solo5/Makefile.uk           |  56 +++++++
>>   plat/solo5/console.c             |  45 +++++
>>   plat/solo5/include/solo5/setup.h |  49 ++++++
>>   plat/solo5/include/solo5/solo5.h | 280 +++++++++++++++++++++++++++++++
>>   plat/solo5/io.c                  |  41 +++++
>>   plat/solo5/irq.c                 |  28 ++++
>>   plat/solo5/lcpu.c                |  75 +++++++++
>>   plat/solo5/link64.lds            |  94 +++++++++++
>>   plat/solo5/memory.c              |  81 +++++++++
>>   plat/solo5/setup.c               |  42 +++++
>>   plat/solo5/shutdown.c            |  37 ++++
>>   plat/solo5/time.c                |  56 +++++++
>>   17 files changed, 965 insertions(+)
>>   create mode 100644 plat/solo5/Config.uk
>>   create mode 100644 plat/solo5/Linker.uk
>>   create mode 100644 plat/solo5/Makefile.uk
>>   create mode 100644 plat/solo5/console.c
>>   create mode 100644 plat/solo5/include/solo5/setup.h
>>   create mode 100644 plat/solo5/include/solo5/solo5.h
>>   create mode 100644 plat/solo5/io.c
>>   create mode 100644 plat/solo5/irq.c
>>   create mode 100644 plat/solo5/lcpu.c
>>   create mode 100644 plat/solo5/link64.lds
>>   create mode 100644 plat/solo5/memory.c
>>   create mode 100644 plat/solo5/setup.c
>>   create mode 100644 plat/solo5/shutdown.c
>>   create mode 100644 plat/solo5/time.c
>>
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel