Re: [Minios-devel] [UNIKRAFT/PTHREAD-EMBEDDED PATCH 0/8] Initial port of pthread-embedded library

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Costin,

thanks for porting this, this will be very helpful. I'll go through this 
now, whenever I have time. As it is an external library, I don't think 
the review standard has to be quite as rigorous as for the internal 
unikraft (where interfaces, file locations, etc. are very important to 
keep things consistent), but I already have some small remarks for the 
first few patches. Should all be easy to resolve so far.
Cheers,
Florian

On 4/15/19 2:43 PM, Costin Lupu wrote:
> This patches introduce support for pthread-embedded to Unikraft.
>
> Costin Lupu (8):
>    Add documentation
>    Add .gitignore
>    patches: Add patches for proper building of original library
>    Initial port of pthread-embedded to Unikraft
>    patches: Fix atomic operations
>    Disable atomic functions
>    Add missing functions for Ruby interpreter
>    include/pthread.h: Guard C code for C++
>
>   .gitignore                                         |  27 +
>   CODING_STYLE.md                                    |   4 +
>   CONTRIBUTING.md                                    |   4 +
>   COPYING.md                                         |  30 ++
>   Config.uk                                          |  30 ++
>   MAINTAINERS.md                                     |  10 +
>   Makefile.uk                                        | 326 +++++++++++++
>   README.md                                          |  11 +
>   exportsyms.uk                                      |  90 ++++
>   include/pte_osal.h                                 |  16 +
>   include/pte_types.h                                |  10 +
>   include/pthread.h                                  |  51 ++
>   include/sys/_pthreadtypes.h                        |   6 +
>   missing_functions.c                                | 153 ++++++
>   ...x-Set-type-size-of-result-used-in-pthread.patch | 494 +++++++++++++++++++
>   ...x-Pass-right-arguments-on-tests-exit4-and.patch |  54 ++
>   ...x-Fix-macro-definitions-for-tests-once3-a.patch |  36 ++
>   ...le-priority-tests-until-we-add-preemptive.patch |  28 ++
>   patches/0005-Use-Unikraft-yield-function.patch     |  22 +
>   ...ader-inclusions-for-functions-from-header.patch |  35 ++
>   patches/0007-Use-atomic-operations-as-macros.patch |  62 +++
>   ...bugfix-Fix-atomic-operations-on-semaphore.patch |  63 +++
>   pte_osal.c                                         | 541 +++++++++++++++++++++
>   23 files changed, 2103 insertions(+)
>   create mode 100644 .gitignore
>   create mode 100644 CODING_STYLE.md
>   create mode 100644 CONTRIBUTING.md
>   create mode 100644 COPYING.md
>   create mode 100644 Config.uk
>   create mode 100644 MAINTAINERS.md
>   create mode 100644 Makefile.uk
>   create mode 100644 README.md
>   create mode 100644 exportsyms.uk
>   create mode 100644 include/pte_osal.h
>   create mode 100644 include/pte_types.h
>   create mode 100644 include/pthread.h
>   create mode 100644 include/sys/_pthreadtypes.h
>   create mode 100644 missing_functions.c
>   create mode 100644 
> patches/0001-tests-bugfix-Set-type-size-of-result-used-in-pthread.patch
>   create mode 100644 
> patches/0002-tests-bugfix-Pass-right-arguments-on-tests-exit4-and.patch
>   create mode 100644 
> patches/0003-tests-bugfix-Fix-macro-definitions-for-tests-once3-a.patch
>   create mode 100644 
> patches/0004-tests-Disable-priority-tests-until-we-add-preemptive.patch
>   create mode 100644 patches/0005-Use-Unikraft-yield-function.patch
>   create mode 100644 
> patches/0006-Separate-header-inclusions-for-functions-from-header.patch
>   create mode 100644 patches/0007-Use-atomic-operations-as-macros.patch
>   create mode 100644 
> patches/0008-bugfix-Fix-atomic-operations-on-semaphore.patch
>   create mode 100644 pte_osal.c
--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel