Re: [Minios-devel] [UNIKRAFT PATCH 1/8] lib/ukdebug: trace.h - introduce UK_FOREACH and UK_NARGS macros

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Hi,

Costin Lupu <costin.lup@xxxxxxxxx> writes:

> H Yuri,
>
> Please see my comments inline.
>
> On 5/10/19 9:29 PM, Yuri Volchkov wrote:
>> +/* Apply function/macro f to every argument passed. Resulting
>> + * arguments are separated with commas
>> + */
>> +#define UK_FOREACH(n, f, ...)                                       \
>> +    UK_CONCAT(UK_FOREACH, n)(f, __VA_ARGS__)
>
> You're right, UK_FOREACH is useful for other modules. For that reason,
> we can get rid of the n parameter and simply define it like this:
>
> +#define UK_FOREACH(f, ...)                                   \
> +     UK_CONCAT(UK_FOREACH, UK_NARGS(__VA_ARGS__))(f, __VA_ARGS__)
That's was done to improve readability. First version had UK_NARGS
everywhere. When I introduced this 'n' parameter it became so much
better.

But I can make an exception for UK_FOREACH, and remove n from there.
>
>> +
>> +#endif /* _UK_TRACE_H_ */
>> 

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel