[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Minios-devel] [UNIKRAFT PATCH 4/8] lib/ukdebug: key-value static storage for tracing
Hi, Costin Lupu <costin.lup@xxxxxxxxx> writes: > And another thing I forgot, please see inline. > > On 5/29/19 8:27 AM, Costin Lupu wrote: >> Hi Yuri, >> >> It's not obvious why we need this key-value thing. Can you please extend >> the commit message or the comment or both with some use cases where this >> would be useful? This is well described in the comment in the code itself. I don't see a point to write the same words in the commit message. And use-case is given too - tracing buffer format version number. >> >> >> Thanks, >> Costin >> >> On 5/10/19 9:29 PM, Yuri Volchkov wrote: >>> + >>> +/* Store a string in format "key = value" in the section >>> + * .uk_trace_keyvals. This can be anything what you want trace.py >>> + * script to know about, and what you do not want to consume any space >>> + * in runtime memory. >>> + * >>> + * This section will be stripped at the final states of building, but >>> + * the key-value data can be easily extracted by: >>> + * >>> + * $ readelf -p .uk_trace_keyvals <your_image.gdb> > > In my case it's not in 'image.gdb', it's in 'image'. Maybe because > 'build: always produce 2 images: w/ and w/o debug syms' wasn't upstreamed? Correct. I unusually write it in the cover letter if my series depends on anything (which is a standard requirement in the mail-list driven community btw): Depends on: "include/essentials.h: introduce compile-time assert" "build: reorganize linking" >> >> _______________________________________________ >> Minios-devel mailing list >> Minios-devel@xxxxxxxxxxxxxxxxxxxx >> https://lists.xenproject.org/mailman/listinfo/minios-devel >> -- Yuri Volchkov Software Specialist NEC Europe Ltd Kurfürsten-Anlage 36 D-69115 Heidelberg _______________________________________________ Minios-devel mailing list Minios-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/minios-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |