[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH] plat/xen: Fix compilation error for Arm32



The patch looks good. Thanks for the fix!

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 16.04.19, 09:23, "Minios-devel on behalf of Florian Schmidt" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
florian.schmidt@xxxxxxxxx> wrote:

    Patch a554f82f unified the symbol definition for linker script symbols.
    They are now all pointers, so they should be used directly instead of
    being referenced.
    
    Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
    ---
     plat/xen/arm/setup.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/plat/xen/arm/setup.c b/plat/xen/arm/setup.c
    index 56f1564..410da92 100644
    --- a/plat/xen/arm/setup.c
    +++ b/plat/xen/arm/setup.c
    @@ -198,7 +198,7 @@ void _libxenplat_armentry(void *dtb_pointer, uint32_t 
physical_offset)
         * TODO: It probably makes sense to move this to the early
         * platform entry assembly code.
         */
    -   memset(&__bss_start, 0, &_end - &__bss_start);
    +   memset(__bss_start, 0, _end - __bss_start);
     
        _init_dtb(dtb_pointer);
        _dtb_init_mem(physical_offset); /* relocates dtb */
    -- 
    2.21.0
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.