[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Minios-devel] [UNIKRAFT/NEWLIB PATCH 2/2] patches: Fix setgroups declaration in origin


  • To: minios-devel@xxxxxxxxxxxxx
  • From: Costin Lupu <costin.lupu@xxxxxxxxx>
  • Date: Wed, 29 May 2019 19:37:25 +0300
  • Cc: felipe.huici@xxxxxxxxx, Florian.Schmidt@xxxxxxxxx, simon.kuenzer@xxxxxxxxx, yuri.volchkov@xxxxxxxxx, sharan.santhanam@xxxxxxxxx
  • Delivery-date: Wed, 29 May 2019 16:37:38 +0000
  • Ironport-phdr: 9a23:b4pdHBHaI41SQroAAWINfJ1GYnF86YWxBRYc798ds5kLTJ76p8u9bnLW6fgltlLVR4KTs6sC17OP9fm6BidZuczJmUtBWaQEbwUCh8QSkl5oK+++Imq/EsTXaTcnFt9JTl5v8iLzG0FUHMHjew+a+SXqvnYdFRrlKAV6OPn+FJLMgMSrzeCy/IDYbxlViDanbr5+MQi6oR/MusUIg4ZuJbs9xgfXrnBVZ+lY2GRkKE6JkR3h/Mmw5plj8ypRu/Il6cFNVLjxcro7Q7JFEjkoKng568L3uxbNSwuP/WYcXX4NkhVUGQjF7Qr1UYn3vyDnq+dywiiaPcnxTbApRTSv6rpgRRH0hCsbMTMy7WfagdFygq1GuhKsvxxxzZDJbo+bN/RweaHSfd0BSGZdQspcTTBND5mgY4cTCecKIOZWr5P6p1sLtRazGw6sBPjzyj9JgH/9wKs00/k5EQHbwQctGM4BsHPPrNXpNacSV/q5zK3VzTXbcvNbwivy6JPSfhA5vPGDRqh8cdDWyUQ2EQ7Ok1aeqZT9Mj+I2ekBrnKX4ulgWO61lWIrtQN8riKhy8s0l4XEiZ8ZxkrH+Ch52oo5O9O1RUBhbdK5H5ZcqSeXPJZsTMw4WWFnoiM6x6UDuZ68YScF1owqxwXaa/yba4iI5Q/jVPqJLTd4mn1lfLW/ig6s8Uil0OL8V8203ExWoSpeiNXMrm0N2AfJ5sidTftx5kah2TCR2ADP8uxIPE85mbfBJ5MiwrM8jIQfvVrBEyPslkj6lKqWeV8l+uis5eTneLLmppqEOoBojQH+Kbgums25AegiNggOQnCb+fmn2bL/5k31Wq1KjuAtnaXDqpDaItwXprSlDA9NzoYj9xG/Ai+j0NQZm3kHLVVFeAmeg4f0JV7OPu73DfOkjlSokTdr3OzGPqb7DpTCMHfDlq3tfbFn605T0AAz18xQ54pICrEdJ/L+Qk//tNjfDh8jMgy72eDnBM9g2IwCWWKPB66ZP77OsVKT4OIgPfWDZIsPtznmMfQq+ePuh2cjmVABZampwYcXaHegE/RoPUqZZXvsgs8fHmsQvgo+Ue3qh0GDUTNIYXa9Qb4z5jUhB429F4vMWJ2tiqSb3CinBp1WenxGCleUHHfzd4WLQe0MZziUIsN7iTwLT76hS5Mh1R60sg/10b9nI/HS+iIGqZ3j0MJ66PbJmR4s6Dx+F96d3H2VT2FogmMIQCc73Lt+oUx4zVeD17J0g/9FFdNN4fNIUxk1NYTHwux8Fd/9RgbBcc2SR1q8XNqmHCk7TsgtzN8Wf0Z9B9KigwjD3iq3Gb8VlqaHBIIz8qLYw3fxJ8V9y3HY1KQ6iVkpXNdANWm8iaFk7QTcGZPJwA2lkPOvdKId2zWI+GqdwG6muEBDTBU2QajDG3cFaRj4t9P8s2jFVKOvD/wDLxNcgZqJLbBWa9uviUheWd/oI5LGfmj3gWDmVkXA/a+FcIe/IzZV5y7aEkVRyw0=
  • Ironport-sdr: ucptA1xdBKdN3mjMsYq1bkPaALUD409fNYXpPtBN6ZCirnkVEKPzr+XZC7qqCslE2P4qsXxmBA LAFD5A7SYVsg==
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>

It seems that the setgroups() declaration is not POSIX. The patch fixes
that.

Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
---
 patches/0004-Fix-setgroups-declaration.patch | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 patches/0004-Fix-setgroups-declaration.patch

diff --git a/patches/0004-Fix-setgroups-declaration.patch 
b/patches/0004-Fix-setgroups-declaration.patch
new file mode 100644
index 0000000..52a9ec7
--- /dev/null
+++ b/patches/0004-Fix-setgroups-declaration.patch
@@ -0,0 +1,28 @@
+From f3e2d3999be2889a559423d03c5bbbbd32d4b8c6 Mon Sep 17 00:00:00 2001
+Date: Wed, 29 May 2019 19:10:31 +0300
+Subject: [PATCH] Fix setgroups declaration
+
+In POSIX, 'ngroups' parameter of 'setgroups' function is of type
+'size_t' instead of 'int'.
+
+Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
+---
+ newlib/libc/include/sys/unistd.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/newlib/libc/include/sys/unistd.h 
b/newlib/libc/include/sys/unistd.h
+index 75f8a51..bcb2f69 100644
+--- a/newlib/libc/include/sys/unistd.h
++++ b/newlib/libc/include/sys/unistd.h
+@@ -188,7 +188,7 @@ int     _EXFUN(seteuid, (uid_t __uid ));
+ int     _EXFUN(setgid, (gid_t __gid ));
+ #endif
+ #if __BSD_VISIBLE
+-int   _EXFUN(setgroups, (int ngroups, const gid_t *grouplist ));
++int   _EXFUN(setgroups, (size_t ngroups, const gid_t *grouplist ));
+ #endif
+ #if __BSD_VISIBLE || (__XSI_VISIBLE && __XSI_VISIBLE < 500)
+ int   _EXFUN(sethostname, (const char *, size_t));
+-- 
+2.11.0
+
-- 
2.11.0


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.