Re: [Minios-devel] [UNIKRAFT PATCH v3 2/7] plat: move common section definitions from linker script to include file

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Florian,

Just one comment here.

On 5/30/19 11:29 PM, Florian Schmidt wrote:
> Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
> ---
>  plat/common/include/common.lds.h | 32 ++++++++++++++++-
>  plat/common/x86/link64.lds       | 59 --------------------------------
>  plat/kvm/arm/link64.lds.S        | 28 ++-------------
>  plat/kvm/x86/link64.lds.S        |  4 ++-
>  plat/linuxu/arm/link.lds.S       | 10 ++----
>  plat/linuxu/x86/link64.lds.S     |  6 +++-
>  plat/xen/arm/link32.lds.S        | 29 ++--------------
>  plat/xen/x86/link64.lds.S        |  4 ++-
>  8 files changed, 49 insertions(+), 123 deletions(-)
>  delete mode 100644 plat/common/x86/link64.lds
> 
> diff --git a/plat/common/include/common.lds.h 
> b/plat/common/include/common.lds.h
> index 8672b6ff..0d28ffff 100644
> --- a/plat/common/include/common.lds.h
> +++ b/plat/common/include/common.lds.h
> @@ -1,6 +1,7 @@
>  /* SPDX-License-Identifier: BSD-3-Clause */
>  /*
> - * Copyright (c) 2019, NEC Laboratories Europe GmbH, NEC Corporation.
> + * Copyright (c) 2019, NEC Laboratories Europe GmbH, NEC Corporation,
> + *                     Politehnica University of Bucharest.

Since we'll have a v4, please change it to "University Politehnica of
Bucharest". I know, it was wrong in the other file.

Thanks,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel