Re: [Minios-devel] [UNIKRAFT PATCH v2 7/8] support/scripts: make uk-trace installable

[Costin Lupu <costin.lup@xxxxxxxxx>]

Yeah, this works.

On 6/1/19 8:50 PM, Yuri Volchkov wrote:
> 
> Costin Lupu <costin.lup@xxxxxxxxx> writes:
> 
>> On 6/1/19 4:06 PM, Yuri Volchkov wrote:
>>> Costin Lupu <costin.lup@xxxxxxxxx> writes:
>>>
>>>> Hi Yuri,
>>>>
>>>> Nope, it doesn't work either. How do you install virtualenv?
>>> I don't remember how did I install it on my working machine. But for
>>> fixing this problems I tested it in the clean docker container
>>> (Ubuntu). I installed it as
>>>
>>>    sudo apt install virtualenv
>>>
>>>> Is this virtualenv a python package? If so, I guess it should also
>>>> work with this command:
>>>>
>>>> python3 -m virtualenv env
>>>>
>>>> If that's true, it fixes only my first problem. Regarding the second
>>>> problem, './env/bin/uk-trace --help' still generates those exceptions.
>>> Now that is strange. Please try to remove your 'env' folder and recreate
>>> it from scratch. Probably something is screwed in your virtual
>>> environment after multiple experiments.
>>>
>>
>> I remove the env directory each time.
> Oh, I am so sorry. I forgot to include in this patch the fix for this
> issue. Would you be so kind to run the test again with the attached
> patch (please git reset --hard the patch I sent earlier).
> 
>>
>>>>
>>>> Anywho, this patch defeats its purpose, one has to install the tools
>>>> which would create the environment which would install the tools needed
>>>> to just parse the parameters of a script - this is waaaay to much of a
>>>> burden for the expected outcome. It's even worse than simply installing
>>>> python-click separately. I think we can get rid of this patch
>>>> altogether.
>>> Ok, let's get back to venv then. One difference (which does help with
>>> your problem) is that virtualenv installs fresh pip and dependencies
>>> into a newly created virtual environment. A similar effect can be
>>> achieved like this:
>>>
>>>    python3 -m venv env
>>>    . env/bin/activate
>>>    pip install --upgrade pip
>>>
>>> BTW, this could actually be the reason why removing '--editable'
>>> helped. Looks like firs run of pip throws an error and fixes the
>>> problem. And any subsequent run does not produce it anymore. So looks
>>> like '--editable' is not the reason at all. But, it is my guess, I don't
>>> really want to dig into setup tools now.
>>>
>>> Anyways, virtual environments are pretty common way of working with
>>> python these days. I still think this patch makes sense. It gives you a
>>> choice.
>>
>> Still doesn't work. And it really doesn't make sense to block an entire
>> series just for a thing like this.
> You are right. But we don't have to wait for all the patches to get
> 'Reviewed-by'. We will upstream on Monday what we already have
> anyways. I am just trying to fix this in the meantime.
> 
> Ok if this did not work, let's force it to upgrade wheel and setuptools
> too. Actually I should have started with this.
> 
>   python3 -m venv env
>   . env/bin/activate
>   cd support/scripts/uk_trace
>   pip install --upgrade pip setuptools wheel
>   pip install --editable .
> 
>>
>> Costin
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel