Re: [Minios-devel] [UNIKRAFT/LIBCXX PATCH] Fix some of the compiling warnings

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin,

This patch looks good.

Thanks,

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>


On 02.06.19, 15:46, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    This patch removes the "unused-parameter" warnings generated by the origin 
code
    and the multiple definition warnings for _LIBCPP_BUILDING_LIBRARY and
    _LIBCPPABI_VERSION macros.
    
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     Makefile.uk | 8 ++++++--
     1 file changed, 6 insertions(+), 2 deletions(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index ddd39da..a455386 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -91,8 +91,8 @@ CXXINCLUDES-$(CONFIG_LIBCXX) += -I$(LIBCXX_SRC)/utils
     
################################################################################
     # Global flags
     
################################################################################
    -CONFIG_FLAGS       += -D _LIBCPP_BUILDING_LIBRARY  -D 
LIBCXX_BUILDING_LIBCXXABI    \
    -           -D _LIBCPPABI_VERSION -D __x86_64__ -D _LIBCPP_STD_VER=15       
\
    +CONFIG_FLAGS       += -D LIBCXX_BUILDING_LIBCXXABI         \
    +           -D __x86_64__ -D _LIBCPP_STD_VER=15     \
                -D _LIBCPP_PROVIDES_DEFAULT_RUNE_TABLE -D __DYNAMIC_REENT__     
\
     
     
    @@ -100,6 +100,10 @@ CONFIG_FLAGS   += -D _LIBCPP_BUILDING_LIBRARY  -D 
LIBCXX_BUILDING_LIBCXXABI    \
     LIBCXX_CFLAGS-y    +=   $(CONFIG_FLAGS)
     LIBCXX_CXXFLAGS-y    +=   $(CONFIG_FLAGS)
     
    +SUPPRESS_FLAGS += -Wno-unused-parameter
    +LIBCXX_CFLAGS-y   += $(SUPPRESS_FLAGS)
    +LIBCXX_CXXFLAGS-y += $(SUPPRESS_FLAGS)
    +
     LIBCXX_SRCS-y += $(LIBCXX_BASE)/glue.c
     
################################################################################
     # Library sources
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel