[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/PTHREAD-EMBEDDED PATCH 8/8] include/pthread.h: Guard C code for C++



This looks fine. I hope I'll remember to set the patch author to Teodora on the upstreaming...

Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

On 4/15/19 1:43 PM, Costin Lupu wrote:
Signed-off-by: Teodora Serbanescu <teo.serbanescu16@xxxxxxxxx>
---
  include/pthread.h | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/pthread.h b/include/pthread.h
index 2f4f7ed..ae6c21b 100644
--- a/include/pthread.h
+++ b/include/pthread.h
@@ -21,13 +21,14 @@
  #ifndef __GLUE_PTHREAD_H__
  #define __GLUE_PTHREAD_H__
-#include_next <pthread.h>
-
-/* C functions not implemented in pthread-embedded */
  #ifdef __cplusplus
  extern "C" {
  #endif
+/* The C code in pthread.h is not guarded for C++ */
+#include_next <pthread.h>
+
+/* C functions not implemented in pthread-embedded */
  int pthread_attr_setguardsize(pthread_attr_t *attr, size_t guardsize);
  int pthread_attr_getguardsize(const pthread_attr_t *attr, size_t *guardsize);

--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.