[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/CLICK PATCH 11/11] config: Add userlevel module option.



Hi Florian,

I was hesitating as to whether this patch should exist at all or not (after 
all, it provides broken functionality), but then again it doesn't hurt to have 
it.

Thanks,

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>


On 02.06.19, 07:53, "Florian Schmidt" <Florian.Schmidt@xxxxxxxxx> wrote:

    Add a menuconfig option to build Click with userlevel elements. Be aware
    that this currently doesn't build because of missing header files.
    Hence, this option is disabled by default.
    
    Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
    ---
     Config.uk   | 7 +++++++
     Makefile.uk | 2 +-
     2 files changed, 8 insertions(+), 1 deletion(-)
    
    diff --git a/Config.uk b/Config.uk
    index 20d9131..aba39f2 100644
    --- a/Config.uk
    +++ b/Config.uk
    @@ -82,4 +82,11 @@ config LIBCLICK_ELEMS_THREADS
        help
          Build with multi-threading elements
     
    +config LIBCLICK_ELEMS_USERLEVEL
    +   bool "Enable userlevel elements [BROKEN]"
    +   default n
    +   help
    +     Build with Click userlevel elements.
    +     Be aware this currently doesn't compile.
    +
     endif
    diff --git a/Makefile.uk b/Makefile.uk
    index 5030ffd..cd2b4c1 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -27,7 +27,7 @@ 
LIBCLICK_EXTRACTED=$(LIBCLICK_ORIGIN)/click-$(LIBCLICK_COMMIT_HASH)
     LIBCLICK_ELEMENTS_DIR=$(LIBCLICK_EXTRACTED)/elements
     LIBCLICK_BUILDTOOL=$(LIBCLICK_EXTRACTED)/bin/click-buildtool
     LIBCLICK_ELEM_DIRS=aqm ethernet etherswitch icmp ip unikraft \
    -              local simple standard tcpudp threads
    +              local simple standard tcpudp threads userlevel
     
     
################################################################################
     # Config Menu - Filter which element categories actually get built
    -- 
    2.21.0
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.