Hi Simon,
Please see inline.
-- Felipe
>>
+################################################################################
>> +# Copy Unikraft from/to devices
>>
+################################################################################
>> +ifneq ($(CONFIG_LIBCLICK_ELEMS_UNIKRAFT),)
>> +$(shell mkdir -p
$(LIBCLICK_ORIGIN)/click-$(LIBCLICK_COMMIT_HASH)/elements)
>> +$(shell cp -r $(LIBCLICK_BASE)/unikraft
$(LIBCLICK_ORIGIN)/click-$(LIBCLICK_COMMIT_HASH)/elements/)
>> +endif
>> +
Oh, you should do this as build rule with according dependencies
instead. You could run this right after the sources got extracted
(depend it on $(LIBCLICK_BUILD)/.origin) and before the configure script
is called. Please also use the provided variables for MKDIR and CP
command and the `verbose_cmd`/`build_cmd` command. As it looks like now,
it copies these files when ever make is involved. This also enforces a
re-compilation of those file all the time. Better to add them as
dependency there, too.
Ok, will do.
>> +################################################################################
>> +# App-specific Targets
>>
+################################################################################
>> +
>> +# Run Click's configure script
>> +$(LIBCLICK_BUILD)/.configured: $(LIBCLICK_BUILD)/.origin
>> + $(call verbose_cmd,CONFIGURE,libapp: $@,\
>> + cd $(LIBCLICK_EXTRACTED) && ./configure --enable-minios
--with-xen=$(LIBCLICK_BUILD) --with-minios=$(LIBCLICK_BUILD) --with-newlib=$(LIBCLICK_BUILD)
--with-lwip=$(LIBCLICK_BUILD) && \
>> + $(TOUCH) $@)
Could you add a short comment why we need to run this configure script
(as example: `bin/click-buildtool` is generated)?
Ok.
