Re: [Minios-devel] [UNIKRAFT PATCH 1/2] lib/nolibc: Add _SC_NPROCESSORS_ONLN define

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Vlad,

On 6/10/19 2:34 PM, Vlad-Andrei BĂDOIU (78692) wrote:
> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
> ---
>  lib/nolibc/include/unistd.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/nolibc/include/unistd.h b/lib/nolibc/include/unistd.h
> index 34dc1f8d..db3b5a6f 100644
> --- a/lib/nolibc/include/unistd.h
> +++ b/lib/nolibc/include/unistd.h
> @@ -46,6 +46,7 @@ extern "C" {
>  #define __NEED_size_t
>  #define __NEED_ssize_t
>  #define __NEED_off_t
> +#define _SC_NPROCESSORS_ONLN 10

I wouldn't have asked for this if it hadn't been the checkpatch issue on
the other patch. But since we'll have a v2, please create here a group
of defines, with a comment stating what they are needed for, e.g.:


  #define __NEED_ssize_t
  #define __NEED_off_t
+
+/*
+ * Sysconf name values
+ */
+#define _SC_NPROCESSORS_ONLN 10
+

>  #include <nolibc-internal/shareddefs.h>
>  
>  unsigned int sleep(unsigned int seconds);
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel