Re: [Minios-devel] [UNIKRAFT PATCH 1/6] lib/ukblkdev: Blkdev Library skeleton.

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

This patch looks fine.

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 29.05.19 10:32, Roxana Nicolescu wrote:
> Add and register libukblkdev library skeleton.
>
> Signed-off-by: Roxana Nicolescu <nicolescu.roxana1996@xxxxxxxxx>
> ---
>   lib/Config.uk            | 1 +
>   lib/Makefile.uk          | 1 +
>   lib/ukblkdev/Config.uk   | 6 ++++++
>   lib/ukblkdev/Makefile.uk | 4 ++++
>   4 files changed, 12 insertions(+)
>   create mode 100644 lib/ukblkdev/Config.uk
>   create mode 100644 lib/ukblkdev/Makefile.uk
>
> diff --git a/lib/Config.uk b/lib/Config.uk
> index 553d4c6b..f391a4f6 100644
> --- a/lib/Config.uk
> +++ b/lib/Config.uk
> @@ -46,3 +46,4 @@ source "lib/ukswrand/Config.uk"
>   source "lib/ukbus/Config.uk"
>   source "lib/uksglist/Config.uk"
>   source "lib/uknetdev/Config.uk"
> +source "lib/ukblkdev/Config.uk"
> diff --git a/lib/Makefile.uk b/lib/Makefile.uk
> index 54a957de..1f8e49bd 100644
> --- a/lib/Makefile.uk
> +++ b/lib/Makefile.uk
> @@ -23,3 +23,4 @@ $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukmpi))
>   $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukbus))
>   $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uksglist))
>   $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uknetdev))
> +$(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukblkdev))
> diff --git a/lib/ukblkdev/Config.uk b/lib/ukblkdev/Config.uk
> new file mode 100644
> index 00000000..b17d6167
> --- /dev/null
> +++ b/lib/ukblkdev/Config.uk
> @@ -0,0 +1,6 @@
> +config LIBUKBLKDEV
> +       bool "ukblkdev: Block driver interface"
> +       default n
> +       select LIBUKALLOC
> +       select LIBNOLIBC if !HAVE_LIBC
> +       select LIBUKDEBUG
> diff --git a/lib/ukblkdev/Makefile.uk b/lib/ukblkdev/Makefile.uk
> new file mode 100644
> index 00000000..62c62045
> --- /dev/null
> +++ b/lib/ukblkdev/Makefile.uk
> @@ -0,0 +1,4 @@
> +$(eval $(call addlib_s,libukblkdev,$(CONFIG_LIBUKBLKDEV)))
> +
> +CINCLUDES-$(CONFIG_LIBUKBLKDEV)                += -I$(LIBUKBLKDEV_BASE)/include
> +CXXINCLUDES-$(CONFIG_LIBUKBLKDEV)      += -I$(LIBUKBLKDEV_BASE)/include
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel