Re: [Minios-devel] [PATCH] include/netinet/tcp.h: Remove TCP_MSS definition

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin, the patch looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 23.06.19, 20:25, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    TCP_MSS definition is already provided by lwipopts.h.
    
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     include/netinet/tcp.h | 8 --------
     1 file changed, 8 deletions(-)
    
    diff --git a/include/netinet/tcp.h b/include/netinet/tcp.h
    index 6b77ff6..0090407 100644
    --- a/include/netinet/tcp.h
    +++ b/include/netinet/tcp.h
    @@ -79,14 +79,6 @@ struct tcphdr {
     #define TCPOPT_TSTAMP_HDR  \
         (TCPOPT_NOP<<24|TCPOPT_NOP<<16|TCPOPT_TIMESTAMP<<8|TCPOLEN_TIMESTAMP)
     
    -/*
    - * Default maximum segment size for TCP.
    - * With an IP MSS of 576, this is 536,
    - * but 512 is probably more convenient.
    - * This should be defined as MIN(512, IP_MSS - sizeof (struct tcpiphdr)).
    - */
    -#define    TCP_MSS 512
    -
     #define    TCP_MAXWIN      65535   /* largest value for (unscaled) window 
*/
     
     #define TCP_MAX_WINSHIFT   14      /* maximum window shift */
    -- 
    2.11.0
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel