Re: [Minios-devel] [UNIKRAFT LWIP PATCH 7/7] Further protect gethostbyname* defines

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Mihai,

Please see inline.

On 6/26/19 4:54 AM, Mihai Pogonaru wrote:
> lwip_gethostbyname and lwip_gethostbyname_r definitions are protected
> by LWIP_DNS && LWIP_SOCKET
> 
> Signed-off-by: Mihai Pogonaru <pogonarumihai@xxxxxxxxx>
> ---
>  include/netdb.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/netdb.h b/include/netdb.h
> index bf5edff..dc636fe 100644
> --- a/include/netdb.h
> +++ b/include/netdb.h
> @@ -1,10 +1,10 @@
> -#if !(LWIP_COMPAT_SOCKETS)
> +#if LWIP_DNS && LWIP_SOCKET && !(LWIP_COMPAT_SOCKETS)
>  
>  #define gethostbyname(name) lwip_gethostbyname(name)
>  #define gethostbyname_r(name, ret, buf, buflen, result, h_errnop) \
>         lwip_gethostbyname_r(name, ret, buf, buflen, result, h_errnop)
>  
> -#endif /* !(LWIP_COMPAT_SOCKETS) */
> +#endif /* LWIP_DNS && LWIP_SOCKET && !(LWIP_COMPAT_SOCKETS) */

Now that see this, why do we define this wrappers at the beginning of
the file, before including the header, and not at the end?

>  
>  #include <compat/posix/netdb.h>
>  
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel