Re: [Minios-devel] [UNIKRAFT VFS PATCH 3/3] Provide functions used by LWIP patch

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Mihai,

If I were very pedantic I would say that here we have 2-in-1 again. But
I understand a bit what you meant with this changes and I would pick
another commit title for it, e.g. "Expose dentry API properly", because
that's what this patch does. And these changes are not needed only by
LWIP, but by all other file descriptor types too.

And please add a commit message saying that it makes more sense to have
the dentry functions in dentry.h.

On 6/26/19 4:54 AM, Mihai Pogonaru wrote:
> Move dentry functions inside dentry.h header and add the ones
> needed by sockets.c in LWIP in exportsyms
> 
> Signed-off-by: Mihai Pogonaru <pogonarumihai@xxxxxxxxx>
> ---
>  lib/vfscore/exportsyms.uk            | 3 +++
>  lib/vfscore/include/vfscore/dentry.h | 7 +++++++
>  lib/vfscore/vfs.h                    | 6 ------
>  3 files changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/vfscore/exportsyms.uk b/lib/vfscore/exportsyms.uk
> index da7fbaea..822e6ecc 100644
> --- a/lib/vfscore/exportsyms.uk
> +++ b/lib/vfscore/exportsyms.uk
> @@ -75,3 +75,6 @@ readlink
>  fallocate
>  lseek
>  uk_syscall_writev
> +dentry_alloc
> +drele
> +vrele
> diff --git a/lib/vfscore/include/vfscore/dentry.h 
> b/lib/vfscore/include/vfscore/dentry.h
> index 85f37ab7..0a384028 100644
> --- a/lib/vfscore/include/vfscore/dentry.h
> +++ b/lib/vfscore/include/vfscore/dentry.h
> @@ -54,4 +54,11 @@ struct dentry {
>       struct uk_list_head d_child_link;
>  };
>  
> +struct dentry *dentry_alloc(struct dentry *parent_dp, struct vnode *vp, 
> const char *path);
> +struct dentry *dentry_lookup(struct mount *mp, char *path);
> +void dentry_move(struct dentry *dp, struct dentry *parent_dp, char *path);
> +void dentry_remove(struct dentry *dp);
> +void dref(struct dentry *dp);
> +void drele(struct dentry *dp);
> +
>  #endif /* _OSV_DENTRY_H */
> diff --git a/lib/vfscore/vfs.h b/lib/vfscore/vfs.h
> index fd60dec7..fb57435f 100644
> --- a/lib/vfscore/vfs.h
> +++ b/lib/vfscore/vfs.h
> @@ -134,12 +134,6 @@ int       vfs_dname_copy(char *dest, const char *src, 
> size_t size);
>  
>  int   fs_noop(void);
>  
> -struct dentry *dentry_alloc(struct dentry *parent_dp, struct vnode *vp, 
> const char *path);
> -struct dentry *dentry_lookup(struct mount *mp, char *path);
> -void dentry_move(struct dentry *dp, struct dentry *parent_dp, char *path);
> -void dentry_remove(struct dentry *dp);
> -void dref(struct dentry *dp);
> -void drele(struct dentry *dp);
>  void dentry_init(void);
>  
>  int vfs_close(struct vfscore_file *fp);
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel