Re: [Minios-devel] [UNIKRAFT PATCHv2 6/7] plat/common: Add a platform API to get IRQ from device tree

["Jianyong Wu (Arm Technology China)" <Jianyong.Wu@xxxxxxx>]

Hi julien,

> -----Original Message-----
> From: Julien Grall <julien.grall@xxxxxxx>
> Sent: Friday, June 21, 2019 6:52 PM
> To: Justin He (Arm Technology China) <Justin.He@xxxxxxx>; minios-
> devel@xxxxxxxxxxxxxxxxxxxx; Simon Kuenzer <simon.kuenzer@xxxxxxxxx>;
> Sharan.Santhanam@xxxxxxxxx
> Cc: Florian Schmidt <florian.schmidt@xxxxxxxxx>; Felipe Huici
> <felipe.huici@xxxxxxxxx>; yuri.volchkov@xxxxxxxxx; Kaly Xin (Arm
> Technology China) <Kaly.Xin@xxxxxxx>; Wei Chen (Arm Technology China)
> <Wei.Chen@xxxxxxx>; Jianyong Wu (Arm Technology China)
> <Jianyong.Wu@xxxxxxx>
> Subject: Re: [UNIKRAFT PATCHv2 6/7] plat/common: Add a platform API to
> get IRQ from device tree
>
> Hi,
>
> On 18/04/2019 07:52, Jia He wrote:
> > From: Wei Chen <wei.chen@xxxxxxx>
> >
> > When we get irq number from device tree, it contains more than one
> > items, like irq type, hardware irq number. This function will help us
> > to translate these items into one unique platfomr irq number.
>
> s/platfomr/platform/
yeah
>
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > Signed-off-by: Jianyong Wu <jianyong.wu@xxxxxxx>
> > Signed-off-by: Jia He <justin.he@xxxxxxx>
> > ---
> > v1->v2: address Sharan's comments
> >
> >   plat/common/include/gic_fdt.h | 47
> ++++++++++++++++++++++++++++++
> >   plat/drivers/gic/gic-v2.c     | 54
> +++++++++++++++++++++++++++++++++--
> >   2 files changed, 99 insertions(+), 2 deletions(-)
> >   create mode 100644 plat/common/include/gic_fdt.h
> >
> > diff --git a/plat/common/include/gic_fdt.h
> > b/plat/common/include/gic_fdt.h new file mode 100644 index
> > 0000000..ba01fcf
> > --- /dev/null
> > +++ b/plat/common/include/gic_fdt.h
> > @@ -0,0 +1,47 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause */
> > +/*
> > + * Authors: Wei Chen <wei.chen@xxxxxxx>
> > + *
> > + * Copyright (c) 2018, Arm Ltd., All rights reserved.
> > + *
> > + * Redistribution and use in source and binary forms, with or without
> > + * modification, are permitted provided that the following conditions
> > + * are met:
> > + *
> > + * 1. Redistributions of source code must retain the above copyright
> > + *    notice, this list of conditions and the following disclaimer.
> > + * 2. Redistributions in binary form must reproduce the above copyright
> > + *    notice, this list of conditions and the following disclaimer in the
> > + *    documentation and/or other materials provided with the distribution.
> > + * 3. Neither the name of the copyright holder nor the names of its
> > + *    contributors may be used to endorse or promote products derived
> from
> > + *    this software without specific prior written permission.
> > + *
> > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS "AS IS"
> > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED
> > +TO, THE
> > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> PARTICULAR
> > +PURPOSE
> > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
> > +CONTRIBUTORS BE
> > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
> > +OR
> > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
> PROCUREMENT
> > +OF
> > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
> > +BUSINESS
> > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
> > +WHETHER IN
> > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
> > +OTHERWISE)
> > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
> > +ADVISED OF THE
> > + * POSSIBILITY OF SUCH DAMAGE.
> > + *
> > + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
> > + */
> > +
> > +#ifndef __PLAT_CMN_GIC_FDT_H__
> > +#define __PLAT_CMN_GIC_FDT_H__
> > +
> > +/**
> > + * Get an interrupt number of given index from device tree
> > + * @param fdt Device tree blob
> > + * @param nodeoffset device node offset
> > + * @param index which interrupt
> > + * @return 0 on success, a negative errno value on errors  */ int
> > +gic_get_irq_from_dtb(const void *fdt, int nodeoffset, int index);
> > +
> > +#endif /* __PLAT_CMN_GIC_FDT_H__ */
> > diff --git a/plat/drivers/gic/gic-v2.c b/plat/drivers/gic/gic-v2.c
> > index 57ab57c..ce38ee9 100644
> > --- a/plat/drivers/gic/gic-v2.c
> > +++ b/plat/drivers/gic/gic-v2.c
> > @@ -48,12 +48,18 @@
> >   /* Max CPU interface for GICv2 */
> >   #define GIC_MAX_CPUIF8
> >
> > -/* SPI interrupt base ID */
> > +/* SPI interrupt definitions */
> > +#define GIC_SPI_TYPE0
> >   #define GIC_SPI_BASE32
> >
> > -/* PPI interrupt base ID */
> > +/* PPI interrupt definitions */
> > +#define GIC_PPI_TYPE1
> >   #define GIC_PPI_BASE16
> >
> > +/* SGI interrupt definitions */
> > +#define GIC_SGI_TYPE2
>
> AFAICT, you can't define SGI in the DT binding [1].


Yeah, I agree. We need no handling for sgi in dtb. I will remove these code.

>
> > +#define GIC_SGI_BASE0
> > +
> >   /* Max support interrupt number for GICv2 */
> >   #define GIC_MAX_IRQ__MAX_IRQ
> >
> > @@ -293,6 +299,34 @@ void gic_set_irq_type(uint32_t irq, int trigger)
> >   write_gicd32(GICD_ICFGR(irq), val);
> >   }
> >
> > +static int gic_irq_translate(int type, int hw_irq)
>
> Mostly likely both arguments should be unsigned.

Ok, I will fix it.
>
> > +{
> > +int irq;
> > +
> > +switch (type) {
> > +case GIC_SPI_TYPE:
> > +irq = hw_irq + GIC_SPI_BASE;
> > +if (irq >= GIC_SPI_BASE && irq < __MAX_IRQ)
> > +return irq;
> > +break;
> > +case GIC_PPI_TYPE:
> > +irq = hw_irq + GIC_PPI_BASE;
> > +if (irq >= GIC_PPI_BASE && irq < GIC_SPI_BASE)
> > +return irq;
> > +break;
> > +case GIC_SGI_TYPE:
> > +irq = hw_irq + GIC_SGI_BASE;
> > +if (irq >= GIC_SGI_BASE && irq < GIC_PPI_BASE)
> > +return irq;
> > +break;
> > +default:
> > +uk_pr_warn("Invalid IRQ type [%d]\n", type);
> > +}
> > +
> > +uk_pr_err("irq is out of range\n");
> > +return -EINVAL;
> > +}
> > +
> >   static void gic_init_dist(void)
> >   {
> >   uint32_t val, cpuif_number, irq_number; @@ -416,3 +450,19 @@ int
> > _dtb_init_gic(const void *fdt)
> >
> >   return 0;
> >   }
> > +
> > +int gic_get_irq_from_dtb(const void *fdt, int nodeoffset, int index)
> > +{
> > +fdt32_t *prop;
> > +int type, hwirq, size;
> > +int ret;
> > +
> > +ret = fdt_get_interrupt(fdt, nodeoffset, index, &size, &prop);
> > +if (ret < 0)
> > +return -EINVAL;
> > +
> > +type = fdt32_to_cpu(prop[0]);
> > +hwirq = fdt32_to_cpu(prop[1]);
> > +
> > +return gic_irq_translate(type, hwirq); }
> >
>
> How do you plan to handle prop[3] (i.e level-sensitive, edge-triggered)?

Er, as far as I know, we can get irq number just by interrupt type and its 
hardware number in dt
And no need to care about its trigger type. So we neglect the prop[3] here.

Thanks
Jianyong wu

>
> Cheers,
>
> [1] linux/Documentation/devicetree/bindings/interrupt-controller
>
> --
> Julien Grall
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel