[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH 1/8] lib/uk9p: Add 9P library skeleton



On 19.06.19 09:03, Cristian Banu wrote:
Add libuk9p skeleton and register it within the build system.

Signed-off-by: Cristian Banu <cristb@xxxxxxxxx>
---
  lib/Config.uk        | 1 +
  lib/Makefile.uk      | 1 +
  lib/uk9p/Config.uk   | 6 ++++++
  lib/uk9p/Makefile.uk | 4 ++++
  4 files changed, 12 insertions(+)
  create mode 100644 lib/uk9p/Config.uk
  create mode 100644 lib/uk9p/Makefile.uk

diff --git a/lib/Config.uk b/lib/Config.uk
index 822c624fd548..9fe837203cda 100644
--- a/lib/Config.uk
+++ b/lib/Config.uk
@@ -47,3 +47,4 @@ source "lib/ukswrand/Config.uk"
  source "lib/ukbus/Config.uk"
  source "lib/uksglist/Config.uk"
  source "lib/uknetdev/Config.uk"
+source "lib/uk9p/Config.uk"
diff --git a/lib/Makefile.uk b/lib/Makefile.uk
index d06837f14338..b1d44d40ab93 100644
--- a/lib/Makefile.uk
+++ b/lib/Makefile.uk
@@ -24,3 +24,4 @@ $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukmpi))
  $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukbus))
  $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uksglist))
  $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uknetdev))
+$(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uk9p))
diff --git a/lib/uk9p/Config.uk b/lib/uk9p/Config.uk
new file mode 100644
index 000000000000..a158f75dec37
--- /dev/null
+++ b/lib/uk9p/Config.uk
@@ -0,0 +1,6 @@
+menuconfig LIBUK9P

If you do not have any configuration parameters, just take config instead of menuconfig. We do not need the sub menu option for this case.

+       bool "uk9p: 9p client and filesystem"

Hum, maybe you remove "and filesystem" and call it just "uk9p: 9p client". It may make people expect that this library implements also a VFScore integration. You have a filesystem integration that you are going to integrate later? In such a case, I think best practice would be to change the name together with those patches later.

+       default n
+       select LIBUKALLOC
+       select LIBNOLIBC if !HAVE_LIBC
+       select LIBUKDEBUG
diff --git a/lib/uk9p/Makefile.uk b/lib/uk9p/Makefile.uk
new file mode 100644
index 000000000000..fa754440598c
--- /dev/null
+++ b/lib/uk9p/Makefile.uk
@@ -0,0 +1,4 @@
+$(eval $(call addlib_s,libuk9p,$(CONFIG_LIBUK9P)))
+
+CINCLUDES-$(CONFIG_LIBUK9P)            += -I$(LIBUK9P_BASE)/include
+CXXINCLUDES-$(CONFIG_LIBUK9P)          += -I$(LIBUK9P_BASE)/include


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.