Re: [Minios-devel] [UNIKRAFT PATCH 0/7] Unikraft Character Device API

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey Costin,

thanks a lot for this patch series. It is a really useful abstraction 
for console/serial devices. I have some minor comments to some of the 
patches. I put them inline in the code.
Thanks,

Simon

On 19.06.19 15:35, Birlea Costin wrote:
> This patch series introduces the character device API, which
> provides a generic interface between character device drivers
> (such as Xen console front and VirtIO console device) and the
> user of the API.
>
> In order for the drivers to register to the API, they need
> to include and use the definitions in consdev_driver.h and to
> implement the functions in uk_consdev_ops.
>
> The API user has first to configure the device, including the
> tx and rx queues, and start the device before being able to
> write to/read from it.
>
> Birlea Costin (7):
>    lib/ukconsdev: Introduce Consdev library skeleton
>    lib/ukconsdev: Register console device
>    lib/ukconsdev: Get console device info/capabilities/etc
>    lib/ukconsdev: Configure console device
>    lib/ukconsdev: Start console device
>    lib/ukconsdev: Read/Write from console device
>    lib/ukconsdev: Enable interrupts on console device
>
>   lib/Config.uk                             |   1 +
>   lib/Makefile.uk                           |   1 +
>   lib/ukconsdev/Config.uk                   |  20 ++
>   lib/ukconsdev/Makefile.uk                 |   6 +
>   lib/ukconsdev/consdev.c                   | 501 ++++++++++++++++++++++++++++++
>   lib/ukconsdev/exportsyms.uk               |  21 ++
>   lib/ukconsdev/include/uk/consdev.h        | 362 +++++++++++++++++++++
>   lib/ukconsdev/include/uk/consdev_core.h   | 267 ++++++++++++++++
>   lib/ukconsdev/include/uk/consdev_driver.h | 109 +++++++
>   9 files changed, 1288 insertions(+)
>   create mode 100644 lib/ukconsdev/Config.uk
>   create mode 100644 lib/ukconsdev/Makefile.uk
>   create mode 100644 lib/ukconsdev/consdev.c
>   create mode 100644 lib/ukconsdev/exportsyms.uk
>   create mode 100644 lib/ukconsdev/include/uk/consdev.h
>   create mode 100644 lib/ukconsdev/include/uk/consdev_core.h
>   create mode 100644 lib/ukconsdev/include/uk/consdev_driver.h
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel