Re: [Minios-devel] [UNIKRAFT PATCHv7 2/8] drivers/ofw: Enable build support for internal fdt interfaces

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Jia He,

This patch seems fine.

My suggestion would be in the next version of the patch series we can 
combine this patch with the previous one where we include the function.
Thanks & Regards
Sharan Santhanam

On 6/27/19 10:55 AM, Jia He wrote:
> This enable the build support for unikraft internal fdt interfaces
>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   plat/kvm/Makefile.uk | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/plat/kvm/Makefile.uk b/plat/kvm/Makefile.uk
> index 71c4c41..18eaca4 100644
> --- a/plat/kvm/Makefile.uk
> +++ b/plat/kvm/Makefile.uk
> @@ -65,6 +65,7 @@ LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/cache64.S|co
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/psci_arm64.S|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/time.c|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/traps.c|common
> +LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_DRIVERS_BASE)/ofw/fdt.c|common
Unfortunately, adding this to files causes compilation error. This was 
related to the previous patch where we include print.h instead of 
assert.h .
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/entry64.S
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/exceptions.S
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/pagetable64.S
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel