Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH] Add patch to support sqlite3

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Gaulthier,

I think a better patch for exporting the lstat function would extend the
condition by checking if __Unikraft__ is defined (please see
attachment). This way we don't break it for the other systems and we
extend it for Unikraft as well.

And I think that the commit message should say that it exports lstat and
mknod, even though this is useful only for sqlite for now.

Cheers,
Costin

On 7/16/19 12:17 PM, gaulthier gain wrote:
> This patch allows to fix the lstat declaration issue to support
> sqlite3.
> 
> Signed-off-by: gaulthier gain <gaulthier.gain@xxxxxxxxx>
> ---
>  ...-sys-stat.h-update-lstat-declaration.patch | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 patches/0005-sys-stat.h-update-lstat-declaration.patch
> 
> diff --git a/patches/0005-sys-stat.h-update-lstat-declaration.patch 
> b/patches/0005-sys-stat.h-update-lstat-declaration.patch
> new file mode 100644
> index 0000000..61fffd0
> --- /dev/null
> +++ b/patches/0005-sys-stat.h-update-lstat-declaration.patch
> @@ -0,0 +1,30 @@
> +From 89fd7effed2b91251d0c74613bbaa23b71ec2b06 Mon Sep 17 00:00:00 2001
> +From: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
> +Date: Mon, 15 Jul 2019 16:05:21 +0200
> +Subject: [UNIKRAFT/NEWLIB PATCH] [PATCH] Update lstat declaration to support
> + sqlite3
> +
> +Signed-off-by: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
> +---
> + newlib/libc/include/sys/stat.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/newlib/libc/include/sys/stat.h b/newlib/libc/include/sys/stat.h
> +index 928c026..8e46c21 100644
> +--- a/newlib/libc/include/sys/stat.h
> ++++ b/newlib/libc/include/sys/stat.h
> +@@ -129,10 +129,10 @@ int    _EXFUN(fstat,( int __fd, struct stat *__sbuf ));
> + int _EXFUN(mkdir,( const char *_path, mode_t __mode ));
> + int _EXFUN(mkfifo,( const char *__path, mode_t __mode ));
> + int _EXFUN(stat,( const char *__restrict __path, struct stat *__restrict 
> __sbuf ));
> ++int _EXFUN(lstat,( const char *__restrict __path, struct stat *__restrict 
> __buf ));
> + mode_t      _EXFUN(umask,( mode_t __mask ));
> + 
> + #if defined (__SPU__) || defined(__rtems__) || defined(__CYGWIN__) && 
> !defined(__INSIDE_CYGWIN__)
> +-int _EXFUN(lstat,( const char *__restrict __path, struct stat *__restrict 
> __buf ));
> + int _EXFUN(mknod,( const char *__path, mode_t __mode, dev_t __dev ));
> + #endif
> + 
> +-- 
> +2.1.4
> +
>

Attachment: PATCH-lstat
Description: Text document

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel